hms-mlkit / huawei-hms-mlkit-sample Goto Github PK

It doesn't make sense to put the binary file into git repo, we can put gradle-wrapper.jar into .gitignore file

Adapt to low resolution mobile phones

在示例代码中，你们使用了自定义View的方式来显示分割的图像，我在换成OpenGl ES的时候，发现你们返回的标志mark数据不能直接使用，能具体说明一下mark的标志的大小和标记吗

Current we are using the template like this:

[TicketNo:]
[Description:]
[Binary Source:]

It's useful if we can associate the issue number with the commit, but what if the commit doesn't have the issue number to add. My suggestion is add a single line of description for the commit after the [TicketNo:]. Just like this:

[TicketNo:] #8 Updated the git log message
[Description:] XXXXX
[Binary Source:] NA

Fix bugs in code

HMS kit is not working on Android 10.
With following error

Installation did not succeed.
The application could not be installed: INSTALL_FAILED_NO_MATCHING_ABIS
Installation failed due to: 'null'

Please try to include the service for android 10

I get an "urlList is empty, failed to detect cloud text" error when I try to recognize the text from the Album right in your sample code.
Please fix it

Optimize the interface interaction experience

It's important that we add License header to the new created files, and there are some gradle tools which can help you check the license header issue. We can easily avoid this kind of issue by introduce a CI check for the License header.

Crash frequently when switching recognition language.

Add CI build and check the correctness of the merged code.

    private int[] byteArrToIntArr(byte[] masks) {
        int[] results = new int[masks.length];
        for (int i = 0; i < masks.length; i++) {
            if (masks[i] == 1) {
                results[i] = Color.BLACK;
            } else if (masks[i] == 2) {
                results[i] = Color.BLUE;
            } else if (masks[i] == 3) {
                results[i] = Color.DKGRAY;
            } else if (masks[i] == 4) {
                results[i] = Color.YELLOW;
            } else if (masks[i] == 5) {
                results[i] = Color.LTGRAY;
            } else if (masks[i] == 6) {
                results[i] = Color.CYAN;
            } else if (masks[i] == 7) {
                results[i] = Color.RED;
            } else if (masks[i] == 8) {
                results[i] = Color.GRAY;
            } else if (masks[i] == 9) {
                results[i] = Color.MAGENTA;
            } else if (masks[i] == 10) {
                results[i] = Color.GREEN;
            } else {
                results[i] = Color.WHITE;
            }
        }
        return results;
    }

What the numbers 1-10 represent?