Giter VIP home page Giter VIP logo

Comments (11)

lstrojny avatar lstrojny commented on September 27, 2024

Digging deeper, this is an issue in hap-nodejs, not in homebridge itself. hap-nodejs defines ambient types for dbus-native already but it doesn’t export those. One possibility could be to submit the ambient types to https://github.com/DefinitelyTyped/DefinitelyTyped/

from hap-nodejs.

github-actions avatar github-actions commented on September 27, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

from hap-nodejs.

github-actions avatar github-actions commented on September 27, 2024

This issue has been closed as no further activity has occurred.

from hap-nodejs.

hjdhjd avatar hjdhjd commented on September 27, 2024

This is a bug / regression to be sure. @Supereg - any direction on how you want to deal with this one?

Current workaround is to lock plugin builds to Homebridge 1.5.1...works, but not ideal.

from hap-nodejs.

Supereg avatar Supereg commented on September 27, 2024

Digging deeper, this is an issue in hap-nodejs, not in homebridge itself. hap-nodejs defines ambient types for dbus-native already but it doesn’t export those. One possibility could be to submit the ambient types to https://github.com/DefinitelyTyped/DefinitelyTyped/

As you found out, we provide an incomplete type declaration file for dbus-native (as it is only used within the project itself). Isn't that enough to package the .d.ts file within the hap-nodejs package? Submitting it to the DefinitlyTyped repository doesn't make sense as the type declaration file isn't complete.

from hap-nodejs.

lstrojny avatar lstrojny commented on September 27, 2024

Good point, shipping the ambient declaration should work just fine

from hap-nodejs.

Supereg avatar Supereg commented on September 27, 2024

Good point, shipping the ambient declaration should work just fine

But then the question is, why did the TypeScript compiler complain? Is there anything wrong with our type definition?

from hap-nodejs.

github-actions avatar github-actions commented on September 27, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

from hap-nodejs.

github-actions avatar github-actions commented on September 27, 2024

This issue has been closed as no further activity has occurred.

from hap-nodejs.

github-actions avatar github-actions commented on September 27, 2024

This issue has been closed as no further activity has occurred.

from hap-nodejs.

Supereg avatar Supereg commented on September 27, 2024

This issue was fixed in the latest beta release and will come live with hap-nodejs 0.11.1 and homebridge 1.6.1.
See #1005

from hap-nodejs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.