humans-of-julia / patternfolds.jl Goto Github PK

It would be nice to have a fold function for any unfolded (normal) container such as fold(v::Vector) that returns an appropriate PatternFold.

This not by far an exhaustive list, just a list of things I think about

• ∈ (necessary for testing rand() without relying on unfold)
• handle unfold for an infinite number of folds

E.g.,

julia> collect(VectorFold([1, 2], 10, -5))
ERROR: ArgumentError: invalid Array dimensions

Proposed fix: create an internal constructor method for VectorFold (and maybe check PatternFold, as well?) to catch this. Would that be reasonable? Or do we...somehow want non-positive numbers of folds? E.g.:

mutable struct VectorFold{T,V <: AbstractVector{T}, I1 <: Integer, I2 <: Integer} <: PatternFold{T,V}
    pattern::V
    gap::T
    folds::I1
    current::I2
	
    function VectorFold(p::V, g::T, f::I1, c::I2) where {T,V <: AbstractVector{T}, I1 <: Integer, I2 <: Integer}
        f < 0 &&
            throw(ArgumentError("folds cannot be negative (you cannot have a negative number of folds)."))
            new{T, V, I1, I2}(p, g, f, c)
        end
end

Make a macro to create folded intervals or vector in the fashion of @view

One interesting point of those PatternFold objects is that it doesn't have to be a discrete container.

We can define IntervalsFold as the union of intervals with the same length and separate by a similar gap

This issue is used to trigger TagBot; feel free to unsubscribe.

If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.

If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

It would be nice to have a nice way to

• pretty print patterns in the terminal/IOStream
• have advance plotting (with pattern highlightning etc.)