Giter VIP home page Giter VIP logo

Comments (3)

zfergus avatar zfergus commented on September 28, 2024

Hi, thank you for pointing this issue out. I replaced the incorrect point_triangle_distance_type with the one used in the original IPC code. I also added some extra tests for the function. Let me know if there are any further problems.

from ipc-toolkit.

lwt831 avatar lwt831 commented on September 28, 2024

It's cool!

BTW, I guess that assert(....toi <= 0) in lines 806, 830 and 853 of ipc.cpp should be changed to assert(...toi <= 1). Is that correct?

from ipc-toolkit.

zfergus avatar zfergus commented on September 28, 2024

Yes, you are right. I pushed a fixed version.

from ipc-toolkit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.