About

As part of investigating jakcron/nstool#95, I discovered an error in the pie::hac::nca::ContentType enum.

In this commit where the code style was changed (7dae44a) pie::hac::nca::ContentType didn't survive the transition.

Program,
Meta,
Control,
Manual,
Data,
PublicData

Became:

ContentType_Program = 0,
ContentType_Meta = 2, // <- should be 1
ContentType_Control = 3, // <- should be 2
ContentType_Manual = 4, // <- should be 3
ContentType_Data = 5, // <- should be 4
ContentType_PublicData = 6 // <- should be 5

Requirements

• Fix the enum typo

About

libpietendo was supposed to replace libnintendo-n3ds & libbroadon-es in https://github.com/3DSGuy/Project_CTR/tree/master/ctrtool/deps however I was too slow to replace it, and enhancements have since been added to libnintendo-n3ds

Task

Bring forward these improvements from libnintendo-n3ds to libpietendo:

• Remove incorrect ExeFS header hash validation. (3DSGuy/Project_CTR#137)
• Update for 9.6 CCI changes (3DSGuy/Project_CTR#135)

The docs don't actually seem to be present any more?

mDataSegmentInfo used HeaderFlags_Ro* instead of HeaderFlags_Data*

mDataSegmentInfo.file_layout.offset = hdr->data.file_offset.unwrap();
mDataSegmentInfo.file_layout.size = hdr->data_file_size.unwrap();
mDataSegmentInfo.memory_layout.offset = hdr->data.memory_offset.unwrap();
mDataSegmentInfo.memory_layout.size = hdr->data.size.unwrap();
mDataSegmentInfo.is_compressed = hdr->flags.test((size_t)nso::HeaderFlags_RoCompress); // <-- HeaderFlags_DataCompress
mDataSegmentInfo.is_hashed = hdr->flags.test((size_t)nso::HeaderFlags_RoHash); // <-- HeaderFlags_DataHash
mDataSegmentInfo.hash = hdr->data_hash;

Hi! :)

When compiling with C++20 (also confirmed with C++17) I've come across this error that prevents compilation.

https://github.com/jakcron/libpietendo/blob/194b77d6ea9077dda6b03a79c593d2c1f2f7e9f2/src/hac/BKTRSubsectionEncryptedStream.cpp#L75C9-L75C9

Location

/src/hac/BKTRSubsectionEncryptedStream.cpp:75

int64_t end_offset = (j + 1 == subsection.header.entry_count) ? subsection.header.end_offset_bucket : subsection.entries[j + 1].offset;

Error message

libpietendo\src\hac\BKTRSubsectionEncryptedStream.cpp(75,137): error C2446: ':': no conversion from 'const tc::bn::le64<int64_t>' to 'const tc::bn::le64<uint64_t>'

no conversion from 'const tc::bn::le64<int64_t>' to 'const tc::bn::le64<uint64_t>'

Possible fix

int64_t end_offset = (j + 1 == subsection.header.entry_count) ? (int64_t) subsection.header.end_offset_bucket : subsection.entries[j + 1].offset;

See here:

I tried to create a GUI to preview the files nstool can read, but many of the process is done in nstool.
Maybe can be a good point move many of the process to libpietendo to allow to use in other projects.
The idea is create fileformat structures in libpietendo that read the structure of the files and then the program that use libpietendo use that structures.

Here can see the idea for the fileformat structures and here the use in nstools