Giter VIP home page Giter VIP logo

Comments (9)

jakearchibald avatar jakearchibald commented on September 27, 2024 3

I'll find some time to take a close look at that. Sorry I haven't so far.

from idb.

jakearchibald avatar jakearchibald commented on September 27, 2024

To make it easier for me to debug this, can you reproduce the issue in the Typescript playground? Here's a demo that shows a cursor with a correct type.

from idb.

vitonsky avatar vitonsky commented on September 27, 2024

@jakearchibald yes, demo with broken types

from idb.

vitonsky avatar vitonsky commented on September 27, 2024

We have to improve type for createObjectStore, to require exists property for keyPath.
We must consider case with a composite keyPath

from idb.

jakearchibald avatar jakearchibald commented on September 27, 2024

It looks like you've just missed part of the value definition? This works.

from idb.

vitonsky avatar vitonsky commented on September 27, 2024

@jakearchibald you're right, we use typescript exactly to avoid data misses. Types for createObjectStore must make impossible a missed property and generate compile time error for such cases

from idb.

jakearchibald avatar jakearchibald commented on September 27, 2024

I'll accept a PR for this if it works, but keyPath is pretty complex.

from idb.

vitonsky avatar vitonsky commented on September 27, 2024

@jakearchibald agree about complexity, maybe i will try to fix when will have time. Let's mark this as bug and needs help

from idb.

dumbmatter avatar dumbmatter commented on September 27, 2024

I think my PR #252 solves this issue - add and put accept an object with or without the auto incrementing keyPath being present, but any object returned from the database has the keyPath value defined. Example

from idb.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.