jalapic / compete Goto Github PK

For the function: get_wl_df
At line 34 and 35 – it makes two new data frames: one for id1 winners (a1) and one for id2 winners (a2) so winners are always in the 1st column and losers in the 2nd column.
At line 36 – it adds a new column to both of these new data frames called “result” to give all id1 values 1 — winners.

However, if there are no id2 winners then the code for assigning a new column to the id2 data frame (a2) does not work.

to do: rewrite devries() in C++

If the third column does not contain "L" then a bug can arise where the functions cannot rbind separate dataframes created from subsetting the data. - need to fix.

Does not work with get_wl_df function when three columns and third is numeric. Need to adjust so works for both W/D/L and 1/0.5/0

I'm unable to install compete because of the following problem:

Warning in install.packages :
  package ‘compete’ is not available (for R version 3.6.1)

Is this a known issue?

to do: rewrite isi98() in C++

domatrix
3 4 5 9
3 0 1 1 7
4 0 0 0 0
5 1 0 0 0
9 0 0 0 0

isi13(domatrix)

Error in if (result[i] == result[i + 1]) { :
missing value where TRUE/FALSE needed

isi98(domatrix)

INITIAL RANK:
[1] "3" "5" "4" "9"
I = 0
SI = 0
$best_matrix
3 5 4 9
3 0 1 1 7
5 1 0 0 0
4 0 0 0 0
9 0 0 0 0

$best_order
[1] "3" "5" "4" "9"

$I
[1] 0

$SI
[1] 0

$rs
[1] 1

"Error in mtxbinom(m) : could not find function "mtxbinom""

I forgot to add this function in the package :(

Include check matrix step at beginning of algorithms to ensure matrix is all numeric.

In the ds function, should say 'type` for all instances of using D/P methods. It says use 'method' in one instance.

These have DESCRIPTION 'Author' fields which contain calls to person()
or as.person(), and hence should be renamed to 'Authors@R' fields (from
which R CMD build will then auto-generated the Author fields).

To do: rewrite isi13() in C++

if input dataframe is generated by e.g. dplyr syntax, it doesn't not identify as only data.frame. Need to use as.data.frame(df) prior to running function.

isi98 doesn't work if rownames don't exist. Need to add colnames to rownames,