Problems parsing SwitchExpr with Unary/BinaryOperators about javaparser HOT 5 CLOSED

Will do! I have a few other tasks keeping be busy, but I'll hopefully get to this at the end of this week or early next

from javaparser.

I introduced this bug in my first java 21 related PR, specifically here where I changed the Expression expected in the switch body to StatementExpression. I did that to fix semi-colon issues with the lexical preserving printer, but didn't consider the fact that not every expression is a statement expression. The tests I wrote all had either empty switch bodies, or print statements in the body, so I didn't cover the expression case. I'm working on a fix now!

from javaparser.

Apparently it is not only unary operators in a SwitchEntry, but also binary operators that cause parser errors.

An additional test follows:

    @Test
    void testSwitchExprWithBinaryExpr() {
        parseStatement("int i = switch (1) {\n" +
                       "    case 1 -> 1;\n" +
                       "    case 2, 3 -> 1 + 2;\n" +
                       "    default -> 1;\n" +
                       "};");
    }

Output:

[ERROR]   SwitchExprTest.testSwitchExprWithBinaryExpr:309 [(line 3,col 18) Parse error. Found "+", expected one of  "%=" "&=" "*=" "++" "+=" "--" "-=" "/=" ";" "<<=" "=" ">>=" ">>>=" "^=" "|="
Problem stacktrace : 
  com.github.javaparser.GeneratedJavaParser.generateParseException(GeneratedJavaParser.java:14249)
  com.github.javaparser.GeneratedJavaParser.jj_consume_token(GeneratedJavaParser.java:14094)
  com.github.javaparser.GeneratedJavaParser.StatementExpression(GeneratedJavaParser.java:6228)
  com.github.javaparser.GeneratedJavaParser.SwitchEntry(GeneratedJavaParser.java:6540)
[...]

Best regards

from javaparser.

@johannescoetzee Can you take a look at this?

from javaparser.

I've opened a PR that fixes this issue.

@Kimmmey thank you very much for the report and the small code examples! This was very useful for diagnosing the issue quickly :)

from javaparser.