Giter VIP home page Giter VIP logo

bifrost.arduino.sensors.hcsr04's People

Contributors

jeremylindsayni avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

bifrost.arduino.sensors.hcsr04's Issues

332m/s = 33200cm/s

line 44 of hcsr04.cpp:

// Given the speed of sound in air is 332m/s = 3320cm/s = 0.0332cm/us).

Endless loop if sensor not present/broken/disconnected

Hi Jeremy,
Many thanks for producing this library!
Found a bug, here is the explanation and the fix.

echoInMicroseconds() function has while loops that if sensor is failing / not present / disconnected will never end.

original code within echoInMicroseconds()

    while(digitalRead(_echo) == LOW);

    int pulseStart = micros();

    while(digitalRead(_echo) == HIGH);

fixed code within echoInMicroseconds()

  // sounds go at 350meters/sec, HCSR04 reach is 4mt, to be safe 10mt, at sound speed takes 28 millis 
   const long timeout=100L; // more than safe in normal conditions.
   long started = millis();
   boolean timedout = false;
   while(digitalRead(_echo) == LOW && !(timedout=(millis()-started > timeout)));
   if (timedout) return -1; // negative distance should be treated as error condition.

   int pulseStart = micros();

   started = millis();
   while(digitalRead(_echo) == HIGH && !(timedout=(millis()-started > timeout)));
   if (timedout) return -1; // negative distance should be treated as error condition.

That's all.
Regards

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.