Comments (6)
kartik-v
commented on September 27, 2024
Thanks for the report. Can you submit a PR for this enhancement?
from yii2-tabs-x.
smohadjer
commented on September 27, 2024
Hi @kartik-v,
Unfortunately moving role="tab" from anchors to list items caused new accessibility issues to appear since an element that is defined as a tab via aria should not have a focusable element like a link inside it. Also we have some other aria attributes on anchor elements that also need to be moved to list item if we move role attribute away from the anchors. After some researching I realized the easiest solution is to add a role="presentation" to list item so assistive technologies understand that this element has no accessibility semantics. This change stopped axe DevTools from showing accessibility issues with my tabs. I have opened a PR here: #83
from yii2-tabs-x.
kartik-v
commented on September 27, 2024
Merged #83.
from yii2-tabs-x.
smohadjer
commented on September 27, 2024
@kartik-v Would you release a new version so we can pick up this fix in our project via composer?
from yii2-tabs-x.
smohadjer
commented on September 27, 2024
@kartik-v Is there any release schedule? I wonder how long we need to wait to pick up this fix.
from yii2-tabs-x.
kartik-v
commented on September 27, 2024
will release it shortly.... missed this.
from yii2-tabs-x.
Related Issues (20)
- tabs-x tab position HOT 1
- Call to undefined method kartik\tabs\TabsXAsset::registerBundle() HOT 3
- Uncaught TypeError: jQuery(...).tabs is not a function HOT 1
- Setting Tab to disabled does not work as described in demo HOT 3
- Can't add options to items HOT 2
- #undefined with stickyTabs enabled and tab with a url instead of direct content HOT 1
- Ajax tab breaks layouts HOT 1
- show filtered array in different tabs HOT 1
- css file is lost HOT 1
- tabsX.click plugin event not working after updating package HOT 2
- Doesn't seem to work with BS 5.x setting HOT 3
- Icons hide in by css in last update HOT 1
- Dropdown divider in TabsX HOT 2
- Gridview filter fails after renderAjax HOT 1
- Solving issue of tabs not changing active class HOT 2
- PluginOptions are not applied
- Loading Icon in ajax-tab not showing on bootstrap5 HOT 1
- Attribute aria-selected doesn't get updated when a tab is clicked
- Template / Pjax
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from yii2-tabs-x.