kaspernj / api_maker Goto Github PK

Since that is built in and used by API maker.

There are more names that shouldn't be allowed so make support for that as well.

It doesn't add a lot of value to have the generated javascript models in version control.
Also, it would be nice to not have to run rails api_maker:generate_models every time a resource is changed.

So, it would be a great improvement, if they could be generated dynamically in development/test.
Then for production, as part of the build, you could run the api_maker:generate_models task.

If a Date- or Time attribute is returned in a resource, it will be read as a Date in JavaScript, because API maker knows the type of the attribute.

If you delegate or otherwise return a custom attribute (where the type is unknown), a Date or Time will be returned as a string.

It should be returned in Ruby as JSON as {type: :date, date: actual_date} or {type: :time, time: actual_time} and then automatically be converted to a Date in JS on the other side.

One for each: BelongsTo, HasMany and HasOne

Collection should use preloaded result from original model, if no other arguments has been given to the query.

If somebody send 1'000 commands and all are getting executed at the same time with_thread the server load can become huge.

Dependabot couldn't find a Gemfile for this project.

Dependabot requires a Gemfile to evaluate your project's current Ruby dependencies. It had expected to find one at the path: /Gemfile.

If this isn't a Ruby project, or if it is a library, you may wish to disable updates for it from within Dependabot.

View the update logs.

when saving array of hashes on nested_attributes (one-to-many) it returns error

undefined method `keys' for #<Array:0x00007f9959d4f838>
.../api_maker-396c2714060c/app/services/api_maker/validation_errors_generator_service.rb:71:in `check_nested_many_models_for_validation_errors'
.../api_maker-396c2714060c/app/services/api_maker/validation_errors_generator_service.rb:55:in `block in inspect_params'

https://github.com/kaspernj/api_maker/blob/master/app/services/api_maker/validation_errors_generator_service.rb#L53-L55

The current Array of attributes is fine if you only need to iterate through them all.
But I would like to look up the type of one attribute.
Having the attributes as either an Object or Map would be good for both those use cases.

Looks like will_paginate has become a mandatory dependency

This should provide better performance and reduce log output by a lot.

I get this error, when running the spec.
Seems to be due to my machine running a different timezone than the CI.

  1) bootstrap - string input renders a datetime local field as sets the value correctly
     Failure/Error: expect(input[:value]).to eq "1985-06-17T10:30:00"
     
       expected: "1985-06-17T10:30:00"
            got: "1985-06-17T12:30:00"
     
       (compared using ==)
     
     
     
     # ./spec/system/bootstrap/string_input_spec.rb:28:in `block (2 levels) in <main>'

Add spec that ensures model names like Ahoy::Message works. This was fixed by using collection keys instead of plural names earlier.

https://d.pr/i/MRthOW
https://d.pr/i/2tlptg

Extract Rails inspection data of validators to the client and let the client perform validation client side to save server side resources and make isValid work.

From README.md

gem "api_maker"

It doesn't work because the gem isn't on rubygems.org.
Could you please create the gem on rubygems.org?