kl13nt / clippy Goto Github PK

Given that features are currently growing in size a better way instead of the intro on the home page is to have a separate "about" window with all the features and disclaimers.

There's a major flaw with the current design. The left click to copy and right click to delete listeners aren't accessible to keyboard users. Thus the whole app is completely useless without a mouse. Adding a context menu or buttons like the pin one would grant more a11y.

• Entry Keyboard Navigation
• Copy Entry Button
• Delete Entry Button
• Pin Entry Button
• Pinned Entry Indication
• Multi-Select Toggle

The new design will be the following:

Describe the bug
about page freezes and is unclosable

To Reproduce
Steps to reproduce the behavior:

1. copy repo
2. npm run dev or npm run make
3. start the program
4. see whats happening

Expected behavior
fully loaded about page

Screenshots

Environment (please complete the following information):

• OS: [e.g. Ubuntu 20.10 64bit]
• Version [e.g. [email protected]]

Possible fix
comment out this line:

add show: true to

Title says it all. Having a bulk delete option would be pretty awesome! The bulk selection algo is already in place and is being used in bulk copy, so why not add a new method bulkDelete or deleteSelection that deletes all currently selected entries? Of course deleting a number of items would require a confirmation prompt, which should be easy as well.

Create a simple task for first time contributors!

https://github.com/hoodiehq/first-timers-bot

Title says it all. When a user clicks a link they're prompted to either:

• Copy it
• Open it
• Copy AND open it

Now, when the choice dialog is shown and the user clicks the 'X' to close it instead of selecting one of the options, it falls back to the else on line index.js:130.

That condition could be replace with an else if to handle this. Should be easy.

Is your feature request related to a problem? Please describe.
I'd like to display the release notes that autoUpdater fetches. When a user restarts Clippy after a successful update that info should be displayed using react-markdown.

1. On autoUpdater update-downloaded store that data in the local app data
2. Set store.isUpdating to true (already done)
3. On launch, check store.isUpdating
4. If true, send event to render process to display release notes
5. Set store.isUpdating and related values to false

Additional context
Make sure to prevent all that when the platform is linux.

Describe the bug
Trying to copy any non-text entity will unselect all the selected entities

To Reproduce
Steps to reproduce the behavior:

1. Copy multiple texts
2. Copy an image
3. Press Shift and select some texts
4. Select an image
5. All entities become unselected

Expected behavior
The alert pop up, the image cannot be selected, and other selected entities will remain the same.

Replace the warning alerts with the following:

• Clear log:
• • Are you sure? (yes, no, don't ask me again)
• Any other operation:
• • Use a timed on-screen notification module (like pollu or facebook)

Describe the solution you'd like

  "husky": {
    "hooks": {
      "commit-msg": "commitlint -E HUSKY_GIT_PARAMS",
      "prepare-commit-msg": "exec < /dev/tty && git cz --hook || true"
    }
  },

Describe the bug
I forgot to handle autoUpdater exceptions. Adding the following code to the updater module should fix it:

autoUpdater.on('error', message => {
  console.error('There was a problem updating the application')
  console.error(message)
})

To Reproduce
Steps to reproduce the behavior:

1. clone this repo
2. install dependencies
3. npm run dev
4. click About in the top-left corner
5. blank page

Expected behavior
page with content

Screenshots

Environment (please complete the following information):

• OS: [Ubuntu 20.10]
• Version [[email protected]]

Additional context
It can be fixed by changing

aboutWindow.loadURL(path.join(__dirname, "about.html"))

to

aboutWindow.loadURL(`file://${__dirname}/about.html`)

Currently Clippy doesn't have a release pipeline, proper versioning, nor any sort of documentation such as contribution guides. This is bad for users who aren't tech-savvy and would like to download this app, and developers that wish to contribute. More info is needed.

[Missing details]

Describe the bug
When you copy some image that is .jpg, Clippy starts to lag and drains computer cpu.

To Reproduce
Steps to reproduce the behavior:

1. copy repo
2. npm run dev or npm run make
3. start the program
4. copy any image from google
5. see whats happening

Screenshots

Environment (please complete the following information):

• OS: [e.g. Ubuntu 20.10 64bit]
• Version [e.g. [email protected]]

Describe the bug
The maintainers haven't responded to my issue yet, so I'll have to implement a work-around in the meantime.

To Reproduce
Steps to reproduce the behavior:

1. npm install
2. npm run release
3. generates wrong version using before-previous-tag commits
4. repeat

Expected behavior
Should just bump version number correctly and generate a proper change log.

Environment (please complete the following information):

• OS: Windows 8.1 Pro
• Version: Clippy 2.0.0

Additional context
We may use npm-version coupled with conventional changelog-cli.

The name says it all. Just a simple

in the render process to display the number of entries in the log.

Todo:

• Jest
• ESLint
• Prettier
• PR Template

To Reproduce
Steps to reproduce the behavior:

1. Copy a link from anywhere
2. See it displayed (in text) as <a> instead of a blue link

Expected behavior
Should be rendered as a blue link

Screenshots

Environment (please complete the following information):

• OS: All environments
• Version [email protected]

Is your feature request related to a problem? Please describe.
An options page is inevitable. Auto-updating is not everyone's cup o' tea. It certainly ain't mine. Giving users more control over it would be nice. Keyboard shortcuts as well.

Describe the solution you'd like
Define a full-page card Preact component page that gives you control over what you wish to modify.

Describe alternatives you've considered
A completely separate page. This page would have a separate entry point in webpack.renderer.config.js and implements simple Preact form validation for settings.

Use these? lol
https://imgur.com/a/I8MUFK9

Description

This feature is implemented in the new Windows 10 clipboard.

• Pinned entries shouldn't be deleted when Clear log is clicked
• There should be a pin icon next to all entries that when clicked pins the respective entry to the top of the list
• Could be a globally attached listener that looks at the element currently pointed at by the cursor, and if it's an entry then display the pin next to it. This would save resources instead of rendering a pin for each entry in the list. This would of-course require adding a data-item=true to the li container.

Is your feature request related to a problem? Please describe.
Syntax highlighting might be fun! I'd love to see the code I copy from online sources to have full syntax highlighting on my clipboard instead of having to copy it back to and editor.

Describe the solution you'd like
react-syntax-highlighter is one of the best libraries for this task.

I think this would be very possible. If on inserting something that's not already on the clipboard then it should be marked as 'onClipboard', and have another state _id pointing to the entry with the id of the entry currently on the clipboard.

The entry in the list could be labelled somehow or just have a constant border/outline.

The direction is not right at all. Modify the JSX to have bidi-friendly rendering in place.

The following shortcuts would make it easier to manage the clipboard:

• CTRL + DELETE - clear clipboard
• SELECT MULTIPLE + DELETE - delete selected entries
• SELECT MULTIPLE + CTRL + C - copy selected entries
• CTRL + SHIFT + DELETE - clear log

This could be implemented in two stages

• Add general listeners for shortcuts
• Add an options page to manage these shortcuts

Is your feature request related to a problem? Please describe.
Having to visit the homepage and manually check and download newer version is cumbersome and not a good UX.

Describe the solution you'd like
I'll look into these:
https://www.electronforge.io/advanced/auto-update
https://www.electronjs.org/docs/tutorial/updates
https://www.electronjs.org/docs/api/auto-updater

Additional context
Must work on both Linux and Windows.

Is your feature request related to a problem? Please describe.
Currently a few instances of changing behavior have come to my attention based on user feedback. Mainly the multi-select behavior and keyboard shortcut management. Providing a minimal settings page to handle that should be better.

Will research this a bit more.

Todo:

• Settings Page
• Menu Item
• Shortcut Controls
• Multi-Select Behavior
• Copied HTML Render Behavior

Describe the bug
Clicking the tray icon should open up the program.

To Reproduce
Steps to reproduce the behavior:

1. Launch Clippy
2. Minimize it to tray
3. Click the tray icon
4. Nothing happens

Expected behavior
Clippy should've been shown again.

Environment (please complete the following information):

• OS: Ubuntu 18 LTS
• Version: [email protected]

Additional context
There's another bug on Kali where the tray icon doesn't show up at all. Perhaps removing the tray entirely and replacing it with normal minimize behavior until I implement a GNOME Extension for it would be better.

Describe the bug
Right clicking an entry on kali linux doesn't provide a proper dialog. The dialog has no clickable options. Options are visible, but not clickable.

To Reproduce

1. Copy anything
2. Right click the entry
3. The dialog that will show up will have no clickable options

Expected behavior
The dialog should be clickable normally.

Screenshots

Environment (please complete the following information):

• OS: Kali Version 2020.3
• Version [email protected]

Description

This may be a bit tricky. Just like everything, holding CTRL or SHIFT while clicking different entries should select all the entries.

Edge Case

There's an edge case that I figured. Choosing multiple text entries should return them as a single \n separated string, while choosing different types is troublesome.

An image AND a text node can't be concatenated, in which case the current selection will accept a single type.

How To

This is a frontend job mostly. Modify the Preact code in render.js to include this. Make sure to add a check in the normal click handler to prevent copying instantly if CTRL is active.

Should include a basic 'exit' option to close the app instead of having to maximize it first.

Describe the bug
It's come to my attention that electron doesn't support tray icons on linux in general. The fix would be to conditionally render the tray on macOS and Windows only, and minimize to taskbar normally on linux otherwise.

Environment:

• OS: All supported linux distributions.
• Version: master

• Setup codecov with GH actions
• Add badge to README https://shields.io/category/coverage
• Add tests for existing functionality

Is your feature request related to a problem? Please describe.
On multiple operating systems, when clicking, holding, and dragging the mouse over a collection of files, all the files in the selection range are selected. If this could be implemented in Clippy it'd make the effort of selecting multiple consecutive entry items a lot easier.

Describe the solution you'd like
Adding a click handler that adds a mousemove listener and creates a rectangular selection zone based on mouse movement may be a way to implement this.

Describe alternatives you've considered
A library exists for this, called SelectionJS. We could either mock its behavior or use it right away. It's only 4 KBs.

Additional context
The behavior would be the same across Windows and Linux since it's rather dependent on the render Chromium process.