Giter VIP home page Giter VIP logo

Comments (3)

dharaneeshvrd avatar dharaneeshvrd commented on September 27, 2024

@cjschaef Please revert back when you get a chance!

from cluster-api-provider-ibmcloud.

dharaneeshvrd avatar dharaneeshvrd commented on September 27, 2024

Raised this PR #1783 to remove the VPC and SecurityGroup field for now to make it simple and if need we can add it back.

from cluster-api-provider-ibmcloud.

cjschaef avatar cjschaef commented on September 27, 2024

The specifications for having a ResourceGroup and VPC defined in the SecurityGroup resource allowed for BYON support to be easier and cleaner.

I will have to re-review and refactor all related VPC functional work to account for the renamed resources and attempt to refactor functionality of SecurityGroup and SGRule creation while keeping the ability of BYON support in mind.

I cannot re-open this issue, so I will open an issue as needed if I indeed have to revert the changes that have been made

from cluster-api-provider-ibmcloud.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.