Giter VIP home page Giter VIP logo

Comments (3)

danielcompton avatar danielcompton commented on September 28, 2024

Another option would be to use git ls-files (https://git-scm.com/docs/git-ls-files). Then you would only need to parse a more straightforward list of files, but more care would be needed in invalidating the list. One other thing to remember which I didn’t see at first glance in some of the code is that you need to look for gitignores up and down the tree

from kaocha.

alysbrooks avatar alysbrooks commented on September 28, 2024

In theory, we could make this broader than .gitignore. I don't want to add extra syntaxes to the original implementation, but we can get support for other ignores almost for free.

  • Ripgrep (rg) and the Silver Searcher (Ag) use .ignore files, which I think uses the same syntax.
  • I think Mercurial ignore files with syntax: glob use a very similar syntax, but I'm not sure it's the same.

That being said, we don't want to use ignore files indiscriminately. It's very plausible someone would put their tests directory in .dockerignore, for example.

from kaocha.

alysbrooks avatar alysbrooks commented on September 28, 2024

This was closed by #189.

from kaocha.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.