Comments (3)
Try the latest version, each property (rootReducer, storeName, and action) now has change detection based on reference equality. The actions will now only change when you set them to a new reference. This should cause a lit-html render using this.action
to only dispatch the action the first time the reference is set. When you set this.action again, the new action should dispatch, even if the object is deeply equivalent. I think this is the desired behavior. Comment if you encounter any more issues with this.
from redux-store-element.
I'll look into this, thanks for the feedback. Let me know of any suggestions you have for how the API should change
from redux-store-element.
Perhaps the simplest thing for redux-store-element to do is implement its own change detection when the action property is set. Probably a reference check would be sufficient so that we don't have to do a deep equality check, and to encourage immutability.
from redux-store-element.
Related Issues (20)
- Test the subscribedtostore event HOT 1
- Example Unit Testing / Mocking HOT 7
- Test the elementId property
- Figure out npm link errors with npm 5 HOT 1
- Infinite recurse for actions
- Automatically run npm run link HOT 1
- missing redux.min.js HOT 3
- stores[this._storeName] = undefined HOT 8
- Figure out CircleCI cache HOT 1
- Add test for firing actions when there are multiple stores
- Update documentation HOT 6
- Look into the attribute change listeners HOT 2
- Add tests for setting properties multiple times
- Each test should define its own unique store name, or clean itself up
- Explain window.process requirement for Redux
- The automated release is failing 🚨
- The automated release is failing 🚨
- The automated release is failing 🚨 HOT 1
- Action Required: Fix Renovate Configuration
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from redux-store-element.