Giter VIP home page Giter VIP logo

Comments (3)

tuxfanx avatar tuxfanx commented on September 27, 2024

@MC-DeltaT
Attached you will find the profile I created.
Unfortunately, I don't have any normal pictures available for testing. Please test it against your photos and report back to us or provide us with relevant pictures.
The slightly different crop factors shouldn't play a role. Their difference is far too small.
You only took pictures at 5 focal lengths. May be 6-7 focal lengths would have been better (e.g. 18, 22, 29, 35, 50, 85, 135mm). However, you could have saved yourself some pictures at the high aperture numbers. Please read here (section "Taking pictures") how the pictures should be taken.
Canon_EF-S_18-135mm_f__5-5.6_IS_USM.zip

from lensfun.

MC-DeltaT avatar MC-DeltaT commented on September 27, 2024

Thanks for the data. I have attached some test images. By my eye, looks like the vignetting is significantly, but not completely, corrected. I'm happy with it though :)

May be 6-7 focal lengths would have been better

I had read that article, but only saw that it says to do 5 focal lengths. Might it be possible to update the article?

test_images.zip

from lensfun.

tuxfanx avatar tuxfanx commented on September 27, 2024

Thanks for your answer.
A correction that is a little too weak is definitely better than a correction that is a little too strong. I will copy the values into the db.
Five focal lengths with 5 aperture stops each are sufficient for most zoom lenses, that's correct. For lenses with a wide zoom range, it can sometimes make sense to add a few more focal lengths.

from lensfun.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.