Server action's error value is not picked up after calling the action with JS/WASM disabled about leptos HOT 7 CLOSED

@gbj when trying to reproduce this in #2321 (comment), did you disable JS?
Edit: obviously you did. Otherwise you wouldn't have the query in the address bar.

from leptos.

from leptos.

Oh, I see. Your example doesn't use the <Router>.

The coordination between the error value stored in the route and the error value stored in the server action is handled by the router. I had the example wrapped in a <Router> because I was pasting it into one of my usual templates.

from leptos.

Indeed, in my small example, it didn't work because the Router is missing. But my actual application uses a Router.

It seems it also doesn't work when using a custom error type (Here: String):

use leptos::*;
use leptos_meta::*;
use leptos_router::*;

#[component]
pub fn App() -> impl IntoView {
    provide_meta_context();

    view! {
        <Router>
            <Routes>
                <Route path="" view=Component/>
            </Routes>
        </Router>
    }
}

#[component]
pub fn Component() -> impl IntoView {
    let action = create_server_action::<Identity>();
    let value = action.value();
    view! {
        <ActionForm action>
            <input type="text" name="x"/>
            <button type="submit">Submit</button>
        </ActionForm>
        {move || format!("{:?}", value.get())}
    }
}

#[server(Identity)]
async fn identity(x: String) -> Result<String, ServerFnError<String>> {
    Err(ServerFnError::from(x))
}

from leptos.

Indeed, in my small example, it didn't work because the Router is missing. But my actual application uses a Router.

It seems it also doesn't work when using a custom error type (Here: String):

Could you clarify: is your actual application using a custom error type, or does "also" here mean this is an additional bug?

from leptos.

This error handling setup is not currently implemented for custom error types.

When a server action is created, it looks for ServerFnUrlError in context

It does not look directly at the URL, because the leptos_server crate this is defined in isn't aware of things like URLs and routing — it does not even have a dependency on web-sys or wasm-bindgen, and is agnostic of whether it's in a browser environment or not. (Server functions can be used outside the browser.)

The ServerFnUrlError is only provided for errors of type ServerFnError, because when the router is checking for errors there's no way of telling it which custom error type that might be that's appeared in the URL:

I guess the alternative here would be to have the router just provide the __path and __err fields directly via context, and let every server action on the page try to decode them to its proper type, if it matches the path. That is probably a better implementation, in fact.

These two features (custom error types and no-JS ActionForm error handling) were introduced separately in 0.6 so the combination just fell through the cracks.

from leptos.

is your actual application using a custom error type, or does "also" here mean this is an additional bug?

My application uses a custom error type.

from leptos.