Giter VIP home page Giter VIP logo

elk's People

Contributors

logant avatar

Stargazers

Ahmad Mokhtar avatar  avatar Ece avatar Gupiod avatar April avatar  avatar Özgürcan İsmailoğulları avatar Richard Frost avatar Wojciech Karnowka avatar Joshua Arcurio avatar  avatar Jialei Shen avatar Praneet Mathur avatar Ehsan Iran-Nejad avatar Kai Zhu avatar  avatar Whoemoon Jang avatar  avatar Hyun Tak avatar İbrahim Serkan UYSAL avatar 倔强的二文鱼 avatar Donovan Wilson avatar Philip Belesky avatar  avatar Nikhil Saraf avatar Yo avatar Andreas Dieckmann avatar  avatar Thomas Vogt avatar

Watchers

Philip Belesky avatar Andreas Dieckmann avatar  avatar Brian Ringley avatar Maarten Vroegindeweij avatar

elk's Issues

featureSubType filtering not applied to Nodes (i.e. single-point data aren't extracted by subcategory)

I've prepared two definitions to illustrate the issue:

  • The first, available here, is a simple case with a small data set
  • The second, available here, is a larger data set that may take longer to load/open

The expected behaviour is that adding a sub category filter would cause the OSMComponent to filter that data to items that match. This happens with multi-point items (ways?) but does not seem to happen with single point items. This makes it much more difficult to extract/classify points of interest - e.g. types of 'craft' shops (as illustrated in the definitions).

Looking at the code paths while using the Budapest data set, unorderedWays contains 112 items so the filtering of allPoints by the parent "craft" category appears to work. I'm still getting a handle on the code, but it looks like only the <way> tags go through a subsequent filtering process to match their subcategory type in line 379 of Processors.cs. There doesn't seem to be anything special about the data used in the two definitions linked above, so I'm assuming this behaviour occurs in all other instances.

I'm not sure if this was a regression or if this was never how Elk worked. Regardless, please let me know if you would be interested in a PR to address this issue / add this feature. I'll likely prepare a change to this effect as part of getting to know the code.

Thanks again for your time and your work with Elk! Please let me know if further details would be helpful.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.