malte-laukoetter / laborus Goto Github PK

Could you create another plugin where u use ur system, like.
What you have:
NPC named Eduard.

Now you use ur actions system

Use right hand on Eduard, do 
msg Eduard $player Hi my friend.
msg Eduard $player Go get some wood for me.
quests add 1 (ID) $player

With /quests check for open quests.

QUESTS:
[1] Eduard: Collect 10 birch wood and bring it to Eduard

If you bring the stuff to him and use ur hand on him with right click again,
another command runs by server.

Quests should be configurable in conf by ID.

EDIT:
There needs to be an check so that you have the stuff in your inventory, like:,
if player has content, do:

remove 10 minecraft:(birch wood)
msg Eduard $player Thx for the stuff.
run the commands

else:
msg Eduard $player You do not have the wood for me.

So it doesn't permanently delete stuff if there is an error in the file.

Laborus Version: 1.6.1
Sponge Version: SpongeForge 1.12.2-2611-7.1.0-BETA-2906
Forge Version: 2611
Sponge API Version: 7.1.0-SNAPSHOT

When using the /jobs command an error appears in the chat window:
Error occured while executing command: Could not initialize class de.lergin.laborus.data.jobkeys

There is also an error while booting the server attached to this as well; possible related

Error when booting (Only happens when Laborus is installed):
Error when running /jobs command:

• usage of the same template strings for all messages
• same format as used for https://github.com/Lergin/Vigilate

SpongePowered/SpongeAPI#1303

Is there any way to create an shortcut like press key 1 to run an skill?

Also support multiple abilities, so you can define fast mining and hammerslash in one job.
Defining shortcut keys for them is avaiable in config.
To do that there need's to be an way to set an MAIN JOB.
The keys you press (the skills you use) depends on the main job if you set multiple jobs as active.

Skills|Abilities of miner (example):

fast mining - like the name says
hammerslash - **Break the next 5 blocks in the direction you look at** (pls add this too :P)

Yet to test this with standard minecraft items but at the least with a mod item (pink apricorn from Pixelmon) there's no experience gain when right-clicking whilst holding the item.

{"defaultLevel":true,"description":"Quite contrary","id":"Gardener","name":"Gardener","actions":{"break":{"items":[]},"place":{"items":[{"item":"pixelmon:pink_apricorn","needLevel":0,"xp":"250"},{"item":"pixelmon:Pink_Apricorn_Tree","needLevel":0,"xp":"500"}]},"damage":{"items":[]},"use":{"items":[{"item":"pixelmon:pink_apricorn","needLevel":0,"xp":"125"},{"item":"pixelmon:Pink_Apricorn_Tree","needLevel":0,"xp":"50"}]},"tame":{"items":[]},"kill":{"items":[]}}}],"maxSelectedJobs":1,"xpWithoutJob":0.5}

There's already one for enchanting, so may as well flag these ones up to :)

A command to reload the configuration while the server is running would help debugging some stuff and also help while creating configurations for jobs.

This is what the overview looks like.
Can u fix it?
Also pls add that you see how much XP is needed for the next level.
Maybe if u mine get the message Miner 102 | 150 XP or Miner 102 of 150 XP

Hello

Once i setup economy for a job and add min and max amount
then reload or restart server
When I go back and check config the min and max value resets to 0. This happens no matter how many time i keep changing it
here is my miner.conf
had to replace .conf to .txt to be able to upload here
miner.txt

Can u pls add that you can define colors for the notifications?

E.g. Miner in green and the XP in grey (make it configurable in the config).

color_job=§2
color_xp=§7

Color Codes

Typical enough - things run when an animal triggers a breed.
Maybe also if you feed them to encourage breeding as well?

If u e.g. mine coal and ur level is not high enough, the blocks just replaces (which is okay) but it drops minecraft level EP|XP.

So u can spam it and get unlimited XP|EP (not job XP).

Bit of an odd-one here but something I'm not aware of anyone else doing - how possible would it be to be able to have things triggered by say distance travelled, or damage taken, or acquiring an achievement and so on?

Not really certain that many / any would want this as a central part of their server, but it'd definitely allow some interesting fluff and story.

It Does Not Seem To Work With API7 I Get Errors Galore When Running

There are some misstakes in conf.
It does not rly matter at this moment :)

description some times ...

Have greater specificity with boni.
As examples:
Get paid 200 if you kill a pig but 50 if you kill a rabbit.
Get a chance of clay to be dropped if you break smooth granite.
Option for a double-drop when mining iron ore but nothing else.

To protect the job progresses of the players for upcoming releases it's needed to put them in an file.
I played hours yesterday and now everything got's beaten :D

@Lergin I summon thee! (please respond :) )

sponge version: SpongeForge 1.12.2-2611-7.1.0-BETA-2906

I'm having a few issues with your plugin:
1.)Cannot join my class (or leave it if it's auto assigned)
2.)Players gain XP with every hit instead of after the block has been destroyed.
3.)i cannot seem to figure out the economy configuration..
4.) It does not get the data from my default levels table in Laborus config; i had to fill the data located in
ex:
Jobs=[
ability=
actions=
bonus={}
description=
id=
level=[
this,
is where,
i have to,
fill it out,
]

not the level=[] that comes prefilled from first load of Laborus.

Can u make it works with Quark ? The server crash when ur plugin and the mod are working together.

https://forums.spongepowered.org/t/laborus-a-completely-customizable-job-plugin/15606/2

• Rather than returning CommandResult.empty() on fail (especially with no message!), it's a good idea to throw CommandException.
• You don't have to construct an array manually for CommandSpec.Builder#arguments, it's a varargs; just put in all the CommandElements normally.
• Use a PaginationList in InfoCommand rather than just repeatedly calling Player#sendMessage; it allows them to scroll through pages via clicking, doesn't spam their chat, and adds a bit of helpful formatting.
• If JobCommand implements CommandExecutor without implementing execute, then you can eliminate both the need for private classes and the getExecutor function.
• Make sure to override toContainer on your immutable manipulator as well.
• If JobDataManipulatorBuilder also extends AbstractDataBuilder, it adds auto-versioning - simply change the public method build to a protected method buildContent, and use the current version number in the call to super() in the constructor. Then, whenever you change the content version, update that number and register a DataContentUpdater, and the data will get updated automatically when first accessed.
• Noticing this in EffectAbility specifically, but might be other places - instead of calling orElse(new ArrayList<>()), call orElseGet(ArrayList::new) - this way, a new ArrayList won't get created every single time the method is run.
• In ItemRepair, you might also wanna test whether or not the durability is already 0, i.e. fully repaired.
• In most of your listeners, the first thing in the top-level if statement, checking if the cause wrapper such as EntityDamageSource is in the Cause, is useless if you already are using annotated arguments. If you meant to check the name as well, you can add a @nAmed annotation to the EntityDamageSource argument.

I deleted the conf files bc it's an new system and all, but the config does not setup by itself.
The files laborus.conf and db creates, but conf with 1 empty line in it.

Option for a percent chance of a command (or multiple) to be ran on an event, or when a specific job level is reached.

Pls make jobs like Blacksmith possible.
Could u add CraftItem to possible actions pls?

Pls limit the amount of numbers after comma.

Pls add in conf file that you can inform about an specific job action in server console.
Like:

        actions {
            # a list of JobItems that award if destroyed
            break=[
                {
                    # an blockstate or blocktype as a string, see http://minecraft.gamepedia.com/Data_values#Block_IDs it also supports blockdata
                    item="minecraft:stone[variant=stone]"
                    needLevel=0
                    xp=1.0
                    console=false
                },

By default it's set to false, but if you test new jobs it's good if you set it true, it's shown in server console.

Does it is currently possible to gain money for JobActions?
If not, pls add :)

Can u make it editable too for the Your level is not high enough message for each job?
So you could message the player with You do not know how to use an {item} (e.g. iron_axe) right now

To hold the overview its needed to put the jobs in external .conf files again :)

Reward on catching a fish.
Maybe for specific type of fish / junk, but I guess that's covered more by inventory mechanics than a trigger for the fishing event.

• Github wiki
• as an Page on Ore

Pls add that you can define permissions per job, e.g. miner.job is needed to change the job to miner.

Pls create an alias of /jobs info, it's not comfortable to check ur xp all the time this way.

/jobs (currently nothing, just not enough args) or /myjob should be the right way.