markeymarke / grocere Goto Github PK

This line passes our history array into the history component. But for some reason, the history component uses its own empty array as a state.

This should be entirely omitted, as we should have a single source of truth, which is the history array in App.js that initializes upon loading the website. We don't need to populate the array anymore, as the users do it overtime in the DB or start with an empty array. As such, a few changes are needed such that history.jsx no longer uses this.state.products in any form.

https://github.com/MarkeyMarke/cmpe133-proj/blob/7fe73a5752662d308ab075881f8c2dbe0ba24293/src/App.js#L93

I'm opening up this issue so we can talk about it right here or on Discord. I have a few ideas to potentially get around this. According to this post: https://stackoverflow.com/questions/37873608/how-do-i-detect-if-a-user-is-already-logged-in-firebase it seems that using var user = firebase.auth().currentUser; from our getUID() function inside firebase.auth().onAuthStateChanged(...) may be a problem. This is because there are probably synchronization issues with doing this. What we could so is that outside of onAuthStateChanged we can just use getUID(), and then check if it's null or not. If it's not null, then we can proceed and set the cart accordingly.

If that doesn't work, then notice how onAuthStateChanged provides a user field in this line: https://github.com/MarkeyMarke/cmpe133-proj/blob/439105cda187089190bab733d62ed9db7ba2c698/src/App.js#L85 with that, perhaps instead of using getUID(), we can just get the user ID directly from that user reference as a property like user.uid, and then set the state using that uid instead.

Clicking the logout button in the aisle section will not update the cart.