An idea for the footer of Markojs.com (URLs to people's pages…) about marko HOT 5 CLOSED

We currently automatically get that contributor information from GitHub’s API. That only provides us the URL of their GitHub profile, unfortunately, but it does show their elsewhere-on-the-web URLs on those profiles?

For example, the Contributors HTML on the Getting Started docs page looks like:

<div class="contributors">
  <a href="https://github.com/DylanPiercey" class="contributor">
    <img src="https://avatars.githubusercontent.com/u/4985201?v=4" alt="" class="photo">
    <span class="name">DylanPiercey</span>
  </a>
  <a href="https://github.com/mlrawlings" class="contributor">
    <img src="https://avatars.githubusercontent.com/u/1958812?v=4" alt="" class="photo">
    <span class="name">mlrawlings</span>
  </a>
  <a href="https://github.com/marko-js/marko/blob/main/packages/marko/docs/getting-started.md" class="contributor you">
    <div class="photo"><span class="icon">+</span></div>
    <span class="name">You?</span>
  </a>
</div>

What page were you not seeing anchors on?

EDIT: Hm, the GitHub API page for User data does list a URL under the blog key and a twitter_username key.

from marko.

What page were you not seeing anchors on?

The main page… I just see “a wall” of photos-&-pictures (of contributors) under the “Join the Community”. And it is not in the “footer” (my mistake), but within the last <section> of <main>: inside its <div class="home-community__contributors">… That <div> – contains just <img>s (which – are not wrapped in <a>s); however, these <img>s do contain URLs of GitHub-profiles, within their src-attribute!

At the same time – I do see “active” (anchored?) images (of contributors) on the «Getting Started»-docs page.

… Finally – here is the place to update the code!

It's here:

<for|contributor| of=body>

from marko.

marko-js/website#89 — the pull request!

from marko.

It seems, I posted this issue on a wrong place: «marko-js/marko» instead of «marko-js/website» (among the repositories).

from marko.

Looks like we forgot to close this 😓

from marko.