Giter VIP home page Giter VIP logo

Comments (4)

mgk avatar mgk commented on September 28, 2024

That makes sense. It used to be one had to list the S3 bucket and then issue batches of download requests which was a pain. Now it looks like TransferManager.downloadDirectory makes that much easier and more efficient.

I'd add keyPrefix and destDir properties to S3Download to indicate a recursive download is desired. Ideally there should also be a timeout property to abort download transfers that take too long. Finally we should add a progress listener to report progress.

I don't need this functionality myself currently, but it makes sense to have so I may give it a go. In the meantime I'd welcome a pull request that used the transfer manager as above.

from s3-plugin.

NickMcAvoy avatar NickMcAvoy commented on September 28, 2024

Progress is underway in my little fork. I have basic downloading implemented, but still print statements in place of real use of the ProgressListener, no timeout, and I didn't figure out how to alternately require key/file or keyPrefix/destDir rather than all four.

from s3-plugin.

NickMcAvoy avatar NickMcAvoy commented on September 28, 2024

Also, I'm new to groovy and doing this a bit hastily, so the code quality could probably be cleaned up.

from s3-plugin.

mgk avatar mgk commented on September 28, 2024

@NickMcAvoy Thanks for getting the ball rolling on this. I implemented recursive downloads as described above except for the timeout property which is directly supported on single file downloads but looks like it requires some additional state management for multi-file downloads.

I've tested it with a handful of files. Let me know how it works for you.

from s3-plugin.

Related Issues (9)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.