[Go] method naming about kiota HOT 8 CLOSED

Thanks for the additional information.
So it'd be fair to say the issue was introduced by 1.13
@NerdJeremia are you seeing this issue with other languages than go? (java for instance)
@andrueastman can you have a look at this when you have a couple of minutes since you're already looking at naming issues with #4517 please?

from kiota.

Thanks for the extra information here on the extra path @NerdJeremia

Looks like this was caused by the path deduplication changes in #4174 that introduced the appending of -id suffix in the situations where path deduplication is performed on indexers.

Authored #4547 to resolve

from kiota.

Hi @NerdJeremia
Thanks for using kiota and for reaching out.
So the change was introduced between 1.11 and 1.13 (inclusive).
Can I ask you to try v1.11, 1.12 so we can narrow done which change might have introduced this please?

Also can you provide the OAS description for that path segment and its parameter please ?(I'm suspecting it's type string, format guid, but I'd like to confirm that)

from kiota.

Hi @baywet
Thank you for the fast response.
In v1.12 its exactly the same and in v1.11 the method is named like this: client.Groups().ByGroupsIdGuid().
As for the the OAS desc it is as follows:

"/groups/{id}": {
      "get": {
        "tags": [
          "Groups"
        ],
        "summary": "Get Group by Id",
        "operationId": "groups_GetById",
        "parameters": [
          {
            "name": "id",
            "in": "path",
            "description": "The id of the group",
            "required": true,
            "schema": {
              "type": "string",
              "format": "uuid"
            }
          }

from kiota.

We are not currently using any other client languages than go so I unfortunately can't say. Yes this issue was apparently introduced in v1.13. However, versions > v1.9 renamed from ByGroupIdGuid to ByGroupsIdGuid which we think also isn't ideal naming.

from kiota.

Hi @baywet Thank you for the fast response. In v1.12 its exactly the same and in v1.11 the method is named like this: client.Groups().ByGroupsIdGuid(). As for the the OAS desc it is as follows:

"/groups/{id}": {
      "get": {
        "tags": [
          "Groups"
        ],
        "summary": "Get Group by Id",
        "operationId": "groups_GetById",
        "parameters": [
          {
            "name": "id",
            "in": "path",
            "description": "The id of the group",
            "required": true,
            "schema": {
              "type": "string",
              "format": "uuid"
            }
          }

@NerdJeremia Just to confirm here, Any chance you can confirm if the description provided is the expected input?
Testing out on #4547 I see that using if the path is "/groups/{id}" will give the indexer method as ByIdGuid.
To get the indexer as ByGroupsIdGuid the path would need to be "/groups/{groups-id}" in original description.

from kiota.

Hi @andrueastman,
for our groups endpoint the path is "/groups/{id}" and for the subresources of a group the path is "/groups/{groupId}/resourceName/{id}".
I generate the all the clients from the same open-api definition just with different versions of kiota.
However the indexer being ByGroupsIdGuid is only a problem in v1.11 and v1.10.
In the latest version we got irritated by the indexer being namen ByGroupIdIdGuid.

from kiota.

Great. Thank you!

from kiota.