Support images in the Card icon prop type about components HOT 10 CLOSED

@tobias-mintlify is this a duplicate of #57

from components.

Reopening, this is a separate issue to allow an image as an icon. This issue is super small and is only about updating the type definition of the component.

#57 is about allowing a big image at the top of the card.

from components.

@tobias-mintlify correct me if I'm wrong. In this updation the icon will accept a href of an image. And the card component will conditionally check is it a image(string) or a svg, right, and based of the condition it will render img and svg respectively.

from components.

Yes exactly. String input gets passed to the image src property. SVGs will still be passed as components.

from components.

Then excited to contribute. Assign me, I will give it a try 😸

from components.

Is it looking good? or it need some modification. If so mention please.

from components.

How can I update this so that icon prop accepts a string as well ??

from components.

That's looking good. If you update the type definition of the component Storybook should automatically start accepting strings too. You can try something like icon?: string | ReactNode.

from components.

That's looking good. If you update the type definition of the component Storybook should automatically start accepting strings too. You can try something like icon?: string | ReactNode.

This is happening although I specified string | ReactNode

Possible reason is ReactNode has string property as literal type

from components.

Its working if we pass a JSON string

from components.