Giter VIP home page Giter VIP logo

Comments (5)

alireza-dhp avatar alireza-dhp commented on September 27, 2024

It should not be possible to create/clone/delete an integration when the study is not in a (Preview) paused state. This behavior has been appeared after PR #442)

Image

from more-studymanager-frontend.

benitsch avatar benitsch commented on September 27, 2024

Code change was introduced by PR #445 (all states except closed) and will be changed by PR #450 (only in draft, pause and preview pause state)

Edit: PR #450 will be closed, since it works as desired and this code change is not needed.

from more-studymanager-frontend.

ja-fra avatar ja-fra commented on September 27, 2024

@alireza-dhp

It should not be possible to create/clone/delete an integration when the study is not in a (Preview) paused state. This behavior has been appeared after PR #442)

From my point of view it should be possible to modify (add, remove, delete) the integrations at all times unless the study has been closed:
Changing the integrations does not affect the study-configuration from a participants perspective. It allows to add/change external services sending data while the study is running: Adding an integration is like changing the password.

An integration is always linked to an (existing) observation - and those can only be changed during a "paused"-state.

from more-studymanager-frontend.

alireza-dhp avatar alireza-dhp commented on September 27, 2024

Thank you for the clarifications @ja-fra .
If this is implemented for the intended purpose, it should be fine.
Previously, we could only perform CRUD operations for integrations while in the "Pause" state (as same as interventions, ...), so I assumed this was overlooked in the last PR.

from more-studymanager-frontend.

alireza-dhp avatar alireza-dhp commented on September 27, 2024

There are two issues/enhancements:

  1. When adding a new integration while the study is "Active," the Integration title field is read-only. It should be enabled and editable. Please ensure this behavior is applied to all states where integrations are modifiable.
    Image

  2. It would be beneficial to edit the Integration title when a user clones the Integration. Currently, the cloned Integration retains the same title, and it cannot be edited afterward since Integrations are not editable.

from more-studymanager-frontend.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.