Recent git update has broken builds using docker images about multibuild HOT 16 OPEN

I think the proper fix is to add safe.directory like in the NumPy fixes. See pypa/manylinux#1309

from multibuild.

I haven't had much luck here so far--please do ping me if you see another project do something useful in this regard, etc.

from multibuild.

I guess multibuild could add git config --global --add safe.directory $1 to the gh_clone function but is that in common use?

from multibuild.

@tylerjereddy - did you try something like Matti's suggestion?

function gh_clone {
    git clone https://github.com/$1
    git config --global --add safe.directory $1
}

from multibuild.

Ah, I did something similar, but it was elsewhere in the control flow. There's also a suggestion from Henry over there: pypa/manylinux#1309 (comment)

Maybe I will try these ideas later today, thanks!

from multibuild.

I see another git step that is actually used by scipy wheels in clean_code, would it be appropriate to add the git config here?

from multibuild.

That looks like a likely spot. git config needs to be added before switching to the build directory, and issuing any other git commands.

from multibuild.

Note that in one case I needed to use --system instead of --global because a root directory wasn't found, that probably isn't a problem here.

from multibuild.

I see the same thing I saw with my previous attempts so far:

2022-05-02T01:50:22.8996044Z fatal: unsafe repository ('/io/scipy' is owned by someone else)
2022-05-02T01:50:22.8997327Z To add an exception for this directory, call:
2022-05-02T01:50:22.8997722Z 
2022-05-02T01:50:22.8998420Z 	git config --global --add safe.directory /io/scipy
2022-05-02T01:50:22.9017913Z fatal: unsafe repository ('/io/scipy' is owned by someone else)
2022-05-02T01:50:22.9018869Z To add an exception for this directory, call:
2022-05-02T01:50:22.9019256Z 
2022-05-02T01:50:22.9019942Z 	git config --global --add safe.directory /io/scipy

from multibuild.

(and then the version number looks weird again)

from multibuild.

I guess you have to apply this command also in the scipy submodule.

from multibuild.

More diagnostic info/local reproducer: MacPython/scipy-wheels#167 (comment)

from multibuild.

Henry's scoping of the git rev-parse command seems to be the key, the git config .. command was useless for me both in CI and locally.

from multibuild.

Hmm. This doesn't directly apply for NumPy, looks like I need to start working on that.

from multibuild.

Found a fix using the config.sh file, see MacPython/numpy-wheels#160. NumPy uses versioneer.

from multibuild.

What worked for me on github actions was adding

if [ $(uname) == "Linux" ]; then
    IS_LINUX=1
    ! git config --global --add safe.directory "*"
fi

to the top of config.sh. I could not figure out the exact directory to make safe.

from multibuild.