nathan-hess / docker-slurm Goto Github PK

Issue
README should have detailed project information, but it contains relatively little detail.

Possible Solutions
Create a detailed README describing repository contents and usage.

Task List

• Update GitHub README
• Update Docker Hub README

Additional Notes
N/A

Issue
Currently, to verify image functionality, the image must be built locally and manually inspected. This is time-consuming and increases the possibility of mistakes.

Possible Solutions
Set up automated tests that check for executables, software versions, etc. to verify that images were built correctly, and require these tests to pass before commits can be merged into main.

Task List

• Create Python unit tests to check for installed software
• Create GitHub Actions workflow to run tests

Additional Notes
N/A

Issue
When building "root" images with Docker Compose, if configuration options in .env are changed to be different from the default build arguments set in the Dockerfiles, the image that is build does not appear to use the modified configuration option but rather reverts to the defaults.

Underlying Cause
It appears that the build arguments are not loaded correctly in docker-compose.yml; that is, the values from .env are not loaded as expected.

Steps to Reproduce Bug
Steps to reproduce the issue, with screenshots (if applicable):

1. Edit a value in .env (for instance, set CONTAINER_UBUNTU_VERSION=20.04)
2. Run docker compose build build-base-root
3. Notice during build, the base image is ubuntu:22.04, not ubuntu:20.04

System Information:

• Hardware: N/A
• Software: Building images on Windows 10 with Docker Desktop v4.8.1

Possible Solutions
In docker-compose.yml, in the x-defaults-build-root section, rather than attempting to inherit build arguments from default-build-args-standard (which appears not to be working), specify all build arguments in both x-defaults-build-standard and x-defaults-build-root.

Task List

• Specify all build arguments separately for both x-defaults-build-standard and x-defaults-build-root sections in docker-compose.yml
• Remove default build argument values in Dockerfiles so errors are thrown if users don't specify necessary build arguments, making errors easier to catch

Additional Notes
N/A