Giter VIP home page Giter VIP logo

Comments (9)

NiklasGollenstede avatar NiklasGollenstede commented on September 1, 2024 1

Ok, found the problem. My workaround to access reader mode content added a display: none to the main page. SumatraPDF ignores such styles, your readers apparently don't. I created a new beta that fixes that and will upload it as the release version soon.
Thanks for telling me!

from epub-creator.

NiklasGollenstede avatar NiklasGollenstede commented on September 1, 2024

Well, I just tried it booth with a website and a book from OverDrive, booth worked as expected.

Could you please provide a specific example (website / bublic sample from your library), or at least specify what you mean by "empty"?

from epub-creator.

rafo avatar rafo commented on September 1, 2024

Hi Niklas, thanx for your fast reply. The Books are only around 9kb and contain 2 empty sites.

Check this sites:

https://www.theatlantic.com/science/archive/2018/08/how-to-write-a-book-without-losing-your-mind/566462/

http://www.spiegel.de/wissenschaft/weltall/tandem-x-satellit-globales-3d-hoehenmodell-der-erde-veroeffentlicht-a-1232884.html

https://www.theatlantic.com/science/archive/2018/10/how-forests-affect-climate-change/572770/

https://www.theverge.com/2018/4/28/17293056/facebook-deletefacebook-social-network-monopoly

https://techcrunch.com/2018/10/13/what-to-expect-from-the-return-of-electric-scooters-in-sf/

I dient find a single one which works ...

Could you send me a link of a website which works? I don't have an Overdrive Account...

from epub-creator.

NiklasGollenstede avatar NiklasGollenstede commented on September 1, 2024

Hm. A file size of just a few kB isn't surprising. (Short) books without images are that small.

Extensions are not allowed to access the content of the reader mode pages, so this extension needs to parse everything itself. The included version of Readability.js was a bit outdated, causing minor differences between the reader page in Firefox and the downloaded content. Also, including cross-origin images didn't work.
In combination that meant that the downloaded books didn't contain any images, but other than that they were fine.

I've now addressed booth problems in the latest beta.
If you are still only seeing blank pages, then that is a problem with your Firefox installation or your ePub reader. Which reader are you using? The last time I checked the produced books were (mostly) ePub 2.0 compliant and they always work in SumatraPDF.

from epub-creator.

rafo avatar rafo commented on September 1, 2024

Hm. A file size of just a few kB isn't surprising. (Short) books without images are that small.

Yes I know. I tested this with different sites (Links on my last comment) and different epub plugins

Extensions are not allowed to access the content of the reader mode pages, so this extension needs to parse everything itself.

I observed this from the other epub creates plugins also. Some of them work with the reader mode some not.

In combination that meant that the downloaded books didn't contain any images, but other than that they were fine.

My books are completely empty. Same with the latest beta.

If you are still only seeing blank pages, then that is a problem with your Firefox installation or your ePub reader.

Newest Firefox (no beta). All plugins deactivated.

Which reader are you using?
iBook (MacOS) and EPUBReader plugin for Firefox. Every other Epub and every other EPUB generated from other Firefox-EPUB-Creation-Plugins works flawless.

from epub-creator.

rafo avatar rafo commented on September 1, 2024

It works! Thank you so much!

from epub-creator.

NiklasGollenstede avatar NiklasGollenstede commented on September 1, 2024

Perfect! That was a silly mistake, but now it works even better than it was supposed to before.
I've just updated the release version as well.

from epub-creator.

rafo avatar rafo commented on September 1, 2024

I will promote this extension since it provides the best EPUBS of all Firefox Extensions. And I tested all of them ;D.

from epub-creator.

NiklasGollenstede avatar NiklasGollenstede commented on September 1, 2024

Thanks, I am glad it is of use to you ( now ;) )

from epub-creator.

Related Issues (17)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.