Giter VIP home page Giter VIP logo

Comments (5)

NiklasGollenstede avatar NiklasGollenstede commented on September 1, 2024

The popup thing is only (hopefully temporarily) necessary, because Firefox no longer lets extensions access the content of the reader mode pages.

First it should say "Loading ...", then prompt to confirm the name, then load some more, and finally change the text to "Done!" and open the save dialog.
The popup can't close itself, because that would also close the save/open dialog. But the popup shpuldn't be blank. It should say "Done!".

The name should be author (if one was found/entered), - , title (which is the title displayed in the reader mode) , plus the extension .epub.
There shouldn't be anything "complex without meaning" (unless that's the websites title).

So I don't see how what you describe could have happened.
I made some minor changes that should make the file naming a bit more ... robust. Please install the new development build (see README) and see if that helps!

from epub-creator.

wolftune avatar wolftune commented on September 1, 2024

Even with development version, given https://www.nytimes.com/2018/12/11/science/chicken-anthropocene-archaeology.html as an example:

I first get this is the dialogue title:
screenshot_20181231_165958

Then after the author entry I get this:
screenshot_20181231_170203

And if I do save, I see _3SzcFyM as the proposed name.

I do have a bunch of privacy-related plugins, but I don't know if that's relevant.

Reader mode looks fine. The plugin somehow still uses the same process as reader mode even though it doesn't access the reader mode directly?

Note: I'm on FF 62.0.3 on KDE Neon which is basically Ubuntu 16.04 (I want to update FF, but the integration with KDE is not updated yet, though I could try removing that and just having generic Ubuntu FF updated)

from epub-creator.

NiklasGollenstede avatar NiklasGollenstede commented on September 1, 2024

Yes, Mozilla provides the reader mode code as a library.

The file name in your screenshot is the URL of the file to download. It seems that your Firefox (profile) simply ignores the name (but note that the file type is correct).
I don't think that can be fixed on my end.
You could try a fresh profile and/or a standard version of Firefox. And I think you should be able to tell Firefox to open the files with the correct program regardless of the name.

from epub-creator.

wolftune avatar wolftune commented on September 1, 2024

I found the issue. It was solved by getting rid of the KDE-focused plasmazilla variant of Firefox and forcing the standard Ubuntu version. Unfortunately, that means I lose KDE native save dialogue. Instead, I am stuck overall with the clunkier GTK-style save dialogue. I hope it will be updated in a way that's compatible at some point. But anyway, I doubt there's anything you can do on your end.

For reference, it's https://launchpad.net/~plasmazilla etc.

from epub-creator.

wolftune avatar wolftune commented on September 1, 2024

Update: I installed latest 18.04-based KDE Neon and however it is set up, Firefox is not based on that plasmazilla PPA at least (I'm using the KDE Neon normal Firefox), and I again have the superior KDE dialogs and epub-creator is also working! Yay!

from epub-creator.

Related Issues (18)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.