Giter VIP home page Giter VIP logo

Comments (11)

nifoc avatar nifoc commented on September 27, 2024 19

If you're using flakes, you can work around this issue by specifying the input as follows:

inputs.neovim-nightly-overlay = {
  url = "github:nix-community/neovim-nightly-overlay";
  # Pin to a nixpkgs revision that doesn't have NixOS/nixpkgs#208103 yet
  inputs.nixpkgs.url = "github:nixos/nixpkgs?rev=fad51abd42ca17a60fc1d4cb9382e2d79ae31836";
};

This is obviously only meant as a temporary workaround.

from neovim-nightly-overlay.

Kranzes avatar Kranzes commented on September 27, 2024 1

Feel free to make a PR here.

from neovim-nightly-overlay.

leiserfg avatar leiserfg commented on September 27, 2024

I tried building the flake in neovim/neovim/contrib by hand and it worked, so the issue seems to be somewhere else.

from neovim-nightly-overlay.

leiserfg avatar leiserfg commented on September 27, 2024

I managed to build by going back to "72ff8b1ca0331a8735c1eeaefb95c12dfe21d30a" and then bumping the neovim-flake to the latest, so the issue seems to be with ninxpkgs, should we keep that version (or use nixpkgs-stable instead of unstable?)

from neovim-nightly-overlay.

nifoc avatar nifoc commented on September 27, 2024

I have submitted a patch to neovim directly: neovim/neovim#21711

The actual cause of this is rather convoluted, so I'm not sure if the upstream patch will be accepted or not.

from neovim-nightly-overlay.

leiserfg avatar leiserfg commented on September 27, 2024

Thanks for the tip.

from neovim-nightly-overlay.

teto avatar teto commented on September 27, 2024

I would rather have this patched here nix-community/neovim-nightly-overlay rather than upstream. Other neovim core contributors accepted to upstream a flake.nix but I dont want to overload them with unnecessary churn.

from neovim-nightly-overlay.

Kranzes avatar Kranzes commented on September 27, 2024

I would rather have this patched here nix-community/neovim-nightly-overlay rather than upstream. Other neovim core contributors accepted to upstream a flake.nix but I dont want to overload them with unnecessary churn.

I actually think now it will be better to upstream it and update upstream's flake.lock.

from neovim-nightly-overlay.

teto avatar teto commented on September 27, 2024

I actually think now it will be better to upstream it and update upstream's flake.lock.

this is a bit short on explanation. The neovim repo is for neovim development, the flake over there is best effort and shouldn't be adapted to whatever patches are added in nixpkgs. I thought this was what this repo was for: check that neovim nightly works with unstable and if not:

  • either pin to the latest working neovim/nixpkgs combination
  • or patch neovim's declaration so that it works.

Btw the reproducibility patch has been merged and will therefore disappear from nixpkgs in the next release.

from neovim-nightly-overlay.

jcdickinson avatar jcdickinson commented on September 27, 2024

Why was this closed?

from neovim-nightly-overlay.

Kranzes avatar Kranzes commented on September 27, 2024

I do not remember doing that, like at all. Sorry.

from neovim-nightly-overlay.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.