Support for ? about js-yaml HOT 9 CLOSED

The problem is not with ?: notation. But with arrays as keys. I'm 100% sure that it was working before, because some JS limitations forced us to explain behavior of arrays as keys in README. In visual example it can be explained as:

var arr = [];
var key = [1,2,3];
arr[key] = 123;
console.log(arr[key]); // -> 123
console.log(arr['1,2,3']); // -> 123

In other words, when you use arrays as key, it become joined with , (commas) before...
Anyway I'm 100% sure it was working before, so it's a kinda regression.

from js-yaml.

Good that I discovered the regression :)

Your library is not yet fully test covered? What testing library are you using? Couldn't get it by looking at the tests quickly.

from js-yaml.

We are in the progress of porting original tests, so in fact it's a home-brew testing suite, but we are going to switch to vows in future.

from js-yaml.

Have a look at http://visionmedia.github.com/mocha/ as well. It also works on the browser.

from js-yaml.

Hm. Probably we will use mocha for this project, yes. The day I was choosing testing framework, vows was the only one that was really good.

from js-yaml.

Yeah Mocha is quite new compared to Vows. It's by TJ so the quality is really high.

from js-yaml.

Looks, like we'll need to drop support of arrays or objects as keys due to JavaScript limitations:

> var obj = {};
undefined
> var arr = [1,2,3];
undefined
> var alt = {foo:'bar'};
undefined
> obj[arr] = true;
true
> obj[alt] = true;
true
> obj
{ '1,2,3': true,
  '[object Object]': true }

As you can see using non-scalars as keys in JS is absolutely unpredictable.

from js-yaml.

I have asked @clarkevans for clarifications, so until his thoughts - suspending issue...

from js-yaml.

As using arrays/objects as keys of objects in JS is really unpredictable, we will not support it. This will be described in README.

from js-yaml.