Giter VIP home page Giter VIP logo

Comments (15)

robertkowalski avatar robertkowalski commented on September 28, 2024

good catch! i opened a PR to adress the problem

from nodejs.org-archive.

misterdjules avatar misterdjules commented on September 28, 2024

@robertkowalski I don't see in this repository the PR you mention, and the problem seems to not be fixed. Could you please create it so that we can merge it and fix this issue?

Thanks!

from nodejs.org-archive.

robertkowalski avatar robertkowalski commented on September 28, 2024

yes @paulomcnally closed the issue

still waiting for a review on nodejs/node-v0.x-archive#9172 - PTAL :)

from nodejs.org-archive.

paulomcnally avatar paulomcnally commented on September 28, 2024

@misterdjules moved to: nodejs/node-v0.x-archive#9172

from nodejs.org-archive.

misterdjules avatar misterdjules commented on September 28, 2024

@robertkowalski Found it: nodejs/node-v0.x-archive#9172.

from nodejs.org-archive.

misterdjules avatar misterdjules commented on September 28, 2024

@paulomcnally Thanks :)

The fix landed in nodejs/node-v0.x-archive@08a1192. With this fix and following our usual workflow, the API doc's table of content would be updated when node v0.12.1 is released. I would like to deploy this fix sooner than that though, as we still don't know when this release will happen.

@tjfontaine @robertkowalski It should be safe to rsync -r out/doc/ [email protected]:~/web/nodejs.org/ right?

from nodejs.org-archive.

misterdjules avatar misterdjules commented on September 28, 2024

I deployed nodejs/node-v0.x-archive@08a1192 to nodejs.org to avoid having to wait for v0.12.1 to fix this annoying and confusing issue.

I cherry-picked nodejs/node-v0.x-archive@08a1192 and diffed the content of the generated api doc, and then ran rsync --dry-run to check which files would be changed. The only change were in the table of content, so I made the decision it was safe to deploy. More details in this gist.

Closing as the TOC at http://nodejs.org/api/ now does not include the tracing module anymore.

Thank you @paulomcnally and @robertkowalski!

from nodejs.org-archive.

paulomcnally avatar paulomcnally commented on September 28, 2024

I use this url to create local documentation https://github.com/nodenica/grunt-node-api-docs-responsive

https://nodejs.org/dist/v0.12.0/docs/api/index.json

tracing link exists on this source :/

from nodejs.org-archive.

robertkowalski avatar robertkowalski commented on September 28, 2024

@misterdjules did you port it to 0.12 ?

from nodejs.org-archive.

misterdjules avatar misterdjules commented on September 28, 2024

The fix has been merged into the v0.12 branch, but not into the v0.12.0-release branch. Thus, it's been deployed to http://nodejs.org/api/, but not to http://nodejs.org/dist/v0.12.0/docs/api.

The v0.12.0 release's artifacts should in my opinion remain intact, and the fix will be present in all subsequent v0.12.x releases.

@paulomcnally Is there a way for you to handle this issue for v0.12.0 in your application?

from nodejs.org-archive.

paulomcnally avatar paulomcnally commented on September 28, 2024

Yes @misterdjules for this version (only for this version) i use /api/index.json and not /dist/v0.12.0/docs/api/index.json.

from nodejs.org-archive.

misterdjules avatar misterdjules commented on September 28, 2024

@paulomcnally /api/index.json will change and will even eventually not point to a v0.12.x version, so you might want to handle this differently.

from nodejs.org-archive.

paulomcnally avatar paulomcnally commented on September 28, 2024

@misterdjules /api/index.json now it's for my custom app. The module use http://nodejs.org/dist/v0.12.0/docs/api/index.json

This solved on next version. From now create a tracing.html empty.

from nodejs.org-archive.

misterdjules avatar misterdjules commented on September 28, 2024

The problem is still present in http://nodejs.org/dist/v0.12.1/docs/api/ because the v0.12.1 release was branched off v0.12.0 and just added the OpenSSL upgrade, thus not including nodejs/node-v0.x-archive@08a1192.

http://nodejs.org/dist/v0.12.2/docs/api/ will definitely not have this problem, sorry for the inconvenience.

from nodejs.org-archive.

paulomcnally avatar paulomcnally commented on September 28, 2024

i know :/

Thanks @misterdjules

from nodejs.org-archive.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.