message names and field names must not collide about openapi2proto HOT 6 CLOSED

So if we're defining the message type for field like this:

properties:
   Foo:
       properties:
           ....

We probably need to declare something like:

message Outer {
   message FooProperty { ... }
   FooProperty Foo = 1;
}

from openapi2proto.

Actually in protobuf terms that should probably be -Message?

Or maybe prefix all the parent messages?

message Foo {
   message FooBar {
       message FooBarBaz {}
   }
}

from openapi2proto.

Meh, prefixing was a bad idea. -Message seems to do the job

from openapi2proto.

Hey @lestrrat, sorry been a busy morning.

In the current version (I believe) we prepend the parent message type to the child type to ensure unique nested message types. What scenario did you run into where this did not work?

from openapi2proto.

@jprobinson no, as I looked in the code ,the only prepended types were enums. Message types did not have anything like that. :/

from openapi2proto.

I guess that bit got lost somewhere along the way (or I'm just being forgetful, v possible 😅).

Based on your explanations in the other thread, I'm cool with the -Message suffix.

from openapi2proto.