Giter VIP home page Giter VIP logo

Comments (5)

oitozero avatar oitozero commented on September 27, 2024

@Hypercubed take a look at 58081b5. not the best solution. if you any suggestion, feel free to add a PR. thanks.

from ngsweetalert.

Hypercubed avatar Hypercubed commented on September 27, 2024

I'm not sure why you have the nested $timeouts... honestly, I'm not sure why you have any of they time outs. Are they needed?

I would try this:

swal: function ( arg1, arg2, arg3 ) {
    var _arg2 = (typeof(arg2) !== 'function') ? arg2 : function(isConfirm){
      arg2(isConfirm);
      $rootScope.$apply();
    };
    swal( arg1, _arg2, arg3 );
},

Edit: fix error in conditional, and forgot apply()

from ngsweetalert.

Hypercubed avatar Hypercubed commented on September 27, 2024

If timeouts are needed (I haven't look at this in detail) perhaps this is more readable:

swal: function ( arg1, arg2, arg3 ) {

  var _arg2 = (typeof(arg2) !== 'function') ? arg2 : function(isConfirm){
    $timeout(function(){
      arg2(isConfirm);
    });
  };

  $timeout(function(){
    swal( arg1, _arg2, arg3 );
  }, 200);
},

from ngsweetalert.

 avatar commented on September 27, 2024

#2 This issue was the reason timeouts were added. I mentioned that this might not be best solution but it made it work so it was an improvement. If your solution still works and displays sweetalerts (on success), submit a PR

from ngsweetalert.

Hypercubed avatar Hypercubed commented on September 27, 2024

I see now. I tried myself, saw the same thing as described in #2. Your implementation works for me... thanks!

from ngsweetalert.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.