Giter VIP home page Giter VIP logo

Comments (7)

dviraran avatar dviraran commented on September 28, 2024

Thanks Gregor.
Just to be clear - "limiting the cell types to immune cells" should be "limiting the cell types to cell types of interest". For example, If you are running it for PBMC and no macrophages are expected, its better to run xCell without them.

from immunedeconv.

grst avatar grst commented on September 28, 2024

ok, I see.

  1. Would it already help to limit the analysis to immune cells, as a default option for the 'naive user'?

  2. For the benchmark, I would consider it as 'fair' to limit xCell to the same cell types that the other methods are using. What do you think?

  3. I am thinking of how to make this accessible to users. Maybe a use_cell_types argument of the deconvolute() function. Maybe you could also implement this on the xCell side as a parameter to the xCellAnalysis function that would wrap the code you show in the tutorial.

from immunedeconv.

dviraran avatar dviraran commented on September 28, 2024
  1. No, because there is almost no spillover between the immune and the other cell types.

  2. Yes. In my experiments, this can significantly improve results for some cell types

  3. Thanks for the suggestion. I added cell.types.use argument to the xCellAnalysis function.

from immunedeconv.

grst avatar grst commented on September 28, 2024

Great! I'll look into this next week.

from immunedeconv.

grst avatar grst commented on September 28, 2024

@dviraran, I now implemented a expected_cell_types parameter for the deconvolute function in the feature/expected_cell_types branch.

At the same time I constrained xCell to the following cell types in the benchmark pipeline for the simulated and FACS data respectively:
https://github.com/grst/immune_deconvolution_benchmark/blob/836b8a631741fb63f3f547ec4a05c7f700e1a9f9/notebooks/config.R#L48

What do you think?

The results did not change a lot. NK cells improved quite a bit, though.
This is what the figures from the manuscript would look like with the modification:

summary
detection_limit_fp
spillover_migration_chart

from immunedeconv.

dviraran avatar dviraran commented on September 28, 2024

Thanks. Looks good to me.
The only reason it bothered me is the apparent failure of xCell in monocytes in the FACS validation (1c,d). I think that it is overcompensating with macrophages, and therefore the correlations look bad. Now its better...
Not sure what is the problem with NK cells.

Best,
Dvir

from immunedeconv.

grst avatar grst commented on September 28, 2024

Great, will update the preprint shortly!

from immunedeconv.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.