Comments (7)
Two more things we need to think of:
-
Could you please check the licenses of the methods, similar to this table? We need to be careful when including GPL-licensed code directly in the package and we'll need to update that table anyway.
-
We'll need to take care of the dependency management. The package has already (too) many dependencies, and I'm a bit wary including more. Maybe the new packages should become optional dependencies, as Konstantin implemented it for omnideconv. Also all dependencies must be available on bioconda. If they are not, we'll need to add them. Could you maybe list the links to all packages and check which methods are already available from bioconda?
from immunedeconv.
In terms of External Dependencies we need to add:
- mMCP counter
- ComICS
- ConsensusTME
None of this packages seems to be available on Bioconda. All the other methods will be added with their source code
Licenses
-
mMCPcounter: GP-3.0
-
seqImmuCC (requires CIBERSORT): CIBERSORT is free for non commercial use, and I am waiting for the authors to confirm the license for the rest
-
DCQ (ComICS package): GPL-2.0
-
BASE: not specified (source code is attached to the published paper)
-
ABIS: GPL-2.0
-
ConsensusTME: GPL-3.0
Datasets
Some datasets should be included in the package as well.
- mouse RNAseq + flow cytometry/FACS data. Just a few samples
- Human PBMC datasets (cf Francesca)
- Human cancer datasets (cf Francesca)
from immunedeconv.
Update from the authors: for the BASE algorithm there is no license so we can use it how we want
from immunedeconv.
Did they say that we can use it specifically? As I understand it, no license means technically you can not use it at all.
from immunedeconv.
@mlist "There is no license for BASE. Feel free to incorporate into your package." This is what they said.
They probably meant that there was no particular restriction
from immunedeconv.
Ok then :)
from immunedeconv.
@LorenzoMerotto, I thin you addressed all of this in #81?
Feel free to close the issue!
from immunedeconv.
Related Issues (20)
- Issue with ESTIMATE inner_join() HOT 3
- Wrong names of ESTIMATE scores HOT 7
- deconvolute_consensus_tme won't work with "Unfiltered" indications HOT 1
- Error message when running CIBERSORT HOT 16
- Error in deconvolute_cibersort HOT 7
- Hi what is the original article to BASE method for deconvolute_mouse()? HOT 1
- Immunedeconv terminates for (non-)duplicate gene symbols HOT 7
- Error by using mouse_genes_to_human function HOT 1
- Unable to load immunedeconv HOT 12
- Error running cibersort HOT 3
- Feature request: BLADE deconvolution method
- [Please-fix-this] Annotation discrepancies in the <immunedeconv::cell_type_map> HOT 5
- map_result_to_celltypes consensus_tme
- Error in `quanTIseq` Deconvolution: Duplicate 'row.names' Not Allowed HOT 1
- Deconvolution analysis - N of 1
- The `path` argument of `write_tsv()` is deprecated as of readr 1.4.0.
- Error in if (max(Y) < 50) { : missing value where TRUE/FALSE needed previous fix not working HOT 1
- Same error as described in issue 79 HOT 2
- None identical gene between eset and reference had been found. Check your eset using: intersect(rownames(eset), rownames(reference)) HOT 2
- Immunedeconv terminates for (non-)duplicate gene symbols HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from immunedeconv.