Giter VIP home page Giter VIP logo

Comments (7)

grst avatar grst commented on September 28, 2024

Two more things we need to think of:

  • Could you please check the licenses of the methods, similar to this table? We need to be careful when including GPL-licensed code directly in the package and we'll need to update that table anyway.

  • We'll need to take care of the dependency management. The package has already (too) many dependencies, and I'm a bit wary including more. Maybe the new packages should become optional dependencies, as Konstantin implemented it for omnideconv. Also all dependencies must be available on bioconda. If they are not, we'll need to add them. Could you maybe list the links to all packages and check which methods are already available from bioconda?

from immunedeconv.

LorenzoMerotto avatar LorenzoMerotto commented on September 28, 2024

In terms of External Dependencies we need to add:

  • mMCP counter
  • ComICS
  • ConsensusTME
    None of this packages seems to be available on Bioconda. All the other methods will be added with their source code

Licenses

  • mMCPcounter: GP-3.0

  • seqImmuCC (requires CIBERSORT): CIBERSORT is free for non commercial use, and I am waiting for the authors to confirm the license for the rest

  • DCQ (ComICS package): GPL-2.0

  • BASE: not specified (source code is attached to the published paper)

  • ABIS: GPL-2.0

  • ConsensusTME: GPL-3.0

Datasets
Some datasets should be included in the package as well.

  • mouse RNAseq + flow cytometry/FACS data. Just a few samples
  • Human PBMC datasets (cf Francesca)
  • Human cancer datasets (cf Francesca)

from immunedeconv.

LorenzoMerotto avatar LorenzoMerotto commented on September 28, 2024

Update from the authors: for the BASE algorithm there is no license so we can use it how we want

from immunedeconv.

mlist avatar mlist commented on September 28, 2024

Did they say that we can use it specifically? As I understand it, no license means technically you can not use it at all.

from immunedeconv.

LorenzoMerotto avatar LorenzoMerotto commented on September 28, 2024

@mlist "There is no license for BASE. Feel free to incorporate into your package." This is what they said.
They probably meant that there was no particular restriction

from immunedeconv.

mlist avatar mlist commented on September 28, 2024

Ok then :)

from immunedeconv.

grst avatar grst commented on September 28, 2024

@LorenzoMerotto, I thin you addressed all of this in #81?
Feel free to close the issue!

from immunedeconv.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.