Comments (9)
I will get to them next week. Good suggestions. I hate the color theme as well.... Don't know if I have time to get to them though....
from cmor.
Another quick comment; in https://github.com/PCMDI/cmor/blob/master/Test/test_python_CMIP6_experimentID.json#L49, the institution_id
is PCMDI
, yet there is no entry for PCMDI
in the institution_ids
in https://github.com/PCMDI/cmor/blob/master/TestTables/CMIP6_CV.json#L120 and CMOR picks BNU
for some reason. In fact, even if I use 'MOHC' as the institution_id
and the correct string for institution
, it still says Your input attribute institution "Met Office Hadley Centre, Fitzroy Road, Exeter, Devon, EX1 3PB, UK." will be replaced with "GCESS,BNU,Beijing,China" as defined in your Control Vocabulary file.
from cmor.
Emma,
This test is to make sure that if you have a bad institution, it will be
replace by the right one. In
https://github.com/PCMDI/cmor/blob/master/Test/test_python_CMIP6_experimentID.json#L49
I have 2 institution_id, the second one "BNU" overwrite the first one.
Sorry about that.
Denis
On 6/20/16 4:40 AM, Emma Hogan wrote:
Another quick comment; in
https://github.com/PCMDI/cmor/blob/master/Test/test_python_CMIP6_experimentID.json#L49,
the |institution_id| is |PCMDI|, yet there is no entry for |PCMDI| in
the |institution_ids| in
https://github.com/PCMDI/cmor/blob/master/TestTables/CMIP6_CV.json#L120
and CMOR picks |BNU| for some reason. In fact, even if I use 'MOHC' as
the |institution_id| and the correct string for |institution|, it
still says |Your input attribute institution "Met Office Hadley
Centre, Fitzroy Road, Exeter, Devon, EX1 3PB, UK." will be replaced
with "GCESS,BNU,Beijing,China" as defined in your Control Vocabulary
file.|—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#69 (comment), or
mute the thread
https://github.com/notifications/unsubscribe/AGnMgmY9YMIjcA5AzXVP7CugyGI8rc7Yks5qNnxEgaJpZM4I3aOh.
from cmor.
Actually, this test is to make sure that user institutionID is in the CV file. If not you get a critical error with an explanation to the. I need to replace the "???" as contact though. 👍
from cmor.
I replaced the "???" character and checked in cmor-master.
from cmor.
Thank you! Would it be possible to reopen this ticket? The items in my first comment haven't yet been dealt with :)
from cmor.
Right now, I really really need to work on the CMIP6 Validator for ESGF. Many people are waiting for it. If you would be so inclined to create a pull request for me, I will merge it. Thanks!
from cmor.
I just tried running the CMIP6 example using CMOR 3.1.1 and it completes without errors :)
Thank you for adding the comments to the CMIP6 example!
I think the only outstanding item is:
- When loading the MIP table, should the line read
table_id = cmor.load_table("CMIP6_Omon.json")
(I was shown a return value when I ran the command in the example)?
I'm happy to submit a pull request if you think it is worthwhile, otherwise this issue can be closed.
Thank you! :)
from cmor.
@ehogan I think this ticket can be closed, we should open a new one with anything pending. It seems that I deleted the "printf" debugging return value from cmor.load_table
.
from cmor.
Related Issues (20)
- Exposing latest netcdf 4.9.x library functionality: quantize, zstandard HOT 13
- Remove unused attributes when processing CMIP6Plus datasets HOT 14
- Exposing latest netcdf 4.9.x library functionality: quantize, zstandard HOT 48
- unclear warning... HOT 5
- bounds required on singleton lon and lat? HOT 5
- avoid attributes of bounds of auxilliary coordinates (`vertices_latitudes` / `vertices_longitude`) HOT 5
- Calibrating CMOR3 & 4 forward development plans HOT 7
- CMOR 3.8.0 Release HOT 4
- Update README.md to remove v3.7 reference
- default `realm = "REALM"` is always written although not required by CV HOT 2
- order in `required_global_attributes` matters HOT 1
- input time type as INT HOT 3
- CircleCI current image deprecated HOT 1
- Numpy 2.0 compatibility issue HOT 2
- File output size and chunking HOT 10
- Message Logging generates duplicated output lines
- DESTDIR support HOT 2
- Failure invoking set_deflate HOT 1
- user defined grid mapping
- Add CITATION.cff file HOT 10
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cmor.