new_record? is not being properly overridden in core_ext.rb about citier HOT 2 OPEN

Hi Ryan,

Thanks for making this an issue, I completely forgot I had to hack round that one!

I identified this issue while creating the gem and I'm afraid I had a bit of a brain blank on this one. It was causing some issues when trying to save up the hierarchy of models since the parent was incorrectly saying it hadn't been saved, which triggered errors preventing the child from saving as well and it all went wrong from there. You are right in thinking I just wrote my own version as a workaround but obviously this is less than ideal!

I attempted to simply override the method in my ActiveRecord class but obviously I should have been overriding in ActiveRecord::Persistence? If so I apologise for my oversight, it's been a tough few weeks of exams!

Thanks for your added change, if you fork and add it I will pull back in?
I am really busy until Friday but if you feel like contributing even further by implementing it correctly and simply changing the few references to my workaround method to the correct one then please go ahead and I will pull in your changes. It's little things like this that are left niggling and making it not quite complete.

Pete

from citier.

Hey Pete,

I found it in Altrabio's code:

def is_new_record(state)
#@new_record = state
@persisted = !state
end

Just make that change and your good to go. No other changes are required elsewhere in your gem.

-Ryan

from citier.