peterscott / murmur3 Goto Github PK

To be C99 compliant, the function declared as inline in murmur3.c need to be declared static inline.

It would also be nice to have a feature test on the gcc inline directive:

# ifdef __GNUC__
# define FORCE_INLINE __attribute__((always_inline))
# else
# define FORCE_INLINE
# endif

It would be nice to have this GPL2 or BSD licensed. This way it could be included in other projects.

So, I retook a look at my code that used this and noticed that with a new version of gcc it now produces this warning.

warning: always_inline function might not be inlinable [-Wattributes]

The problem is described here: http://comments.gmane.org/gmane.linux.bluez.kernel/22080
The fix is apparently to add inline in addition to the always_inline stuff.

So the fix:

# ifdef __GNUC__
# define FORCE_INLINE __attribute__((always_inline)) inline
# else
# define FORCE_INLINE
# endif