Comments (5)
Adam-it
commented on August 31, 2024
1
I think you are also right here as well
from action-cli-deploy.
waldekmastykarz
commented on August 31, 2024
1
Good catch! We should bump the major version of this action and in the docs clearly indicate that it can be used only with v6. For older versions of the CLI folks should use the v2 of this action.
from action-cli-deploy.
milanholemans
commented on August 31, 2024
@pnp/cli-for-microsoft-365-maintainers we should also consider this upcoming bug.
from action-cli-deploy.
FredrikEkstroem
commented on August 31, 2024
A question related to this change, when running pnp/[email protected] without CLI_VERSION specified the latest CLI will be installed? And when 6.0 is available in npm, the old versions will break if not updated to pnp/[email protected]? Or will the --scope still be there marked as deprecated for a while?
from action-cli-deploy.
milanholemans
commented on August 31, 2024
A question related to this change, when running pnp/[email protected] without CLI_VERSION specified the latest CLI will be installed?
Yes correct!
And when 6.0 is available in npm, the old versions will break if not updated to pnp/[email protected]? Or will the --scope still be there marked as deprecated for a while?
Since the latest version of the CLI will be installed, the GitHub action will indeed fail because we renamed the options in v6. One time per year we release a new major version which contains breaking changes, so once per year we can remove deprecated options etc. However now you are talking about the pnp/action-cli-login repo. That repo will not be suffering from the breaking changes, only this repo will.
from action-cli-deploy.
Related Issues (11)
- spo app add does not return App Id only anymore HOT 6
- Dependabot alerts HOT 2
- Maintenance Updates HOT 1
- `spo app add` not returning `UniqueId` anymore. HOT 4
- Create Office 365 CLI deploy app GitHub action HOT 1
- Invalid option "scope" when deploying HOT 7
- Publish the GitHub action on the marketplace HOT 3
- --skipFeatureDeployment not included in spo app deploy command on Windows HOT 10
- Update the documentation to use master instead of v1.0.0 HOT 1
- Site collection admins are not allowed to deploy HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from action-cli-deploy.