Giter VIP home page Giter VIP logo

engines-wrapper's Introduction

engines-wrapper's People

Contributors

aqrln avatar janpio avatar jkomyno avatar jolg42 avatar millsp avatar pantharshit00 avatar prisma-bot avatar renovate-bot avatar renovate[bot] avatar sevinf avatar timsuchanek avatar tomhoule avatar v-zhzhou avatar williamluke4 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

engines-wrapper's Issues

Manual Engines releases (in branches/PRs) create a normal engines-wrapper release here, but nothing on `prisma/prisma`

Example:
prisma/prisma-engines#2208 (original)
prisma/prisma-engines#2196 (copy in our repo)
https://buildkite.com/prisma/release-prisma-engines/builds/1596
https://github.com/prisma/engines-wrapper/actions/runs/1197982488
https://github.com/prisma/engines-wrapper/runs/3506044105?check_suite_focus=true
b112a3a
2.31.0-25.node-api-threadsafe-unref-1ca259332bad49e28dd3eda822c358a766b3ec08

See how the GH Actions run skips the Workflow dispatch to prisma/prisma for version update step. One way this is great, as it does not automatically create a new dev version. On the other hand we do not get an automatic version with this engine.

Should maybe auto create an integration branch of the same name and open a PR? (via triggering a special version of the workflow on prisma/prisma)

Share build logic with `prisma/prisma`

Right now, this repository is falling behind in terms of eslint, typescript, and esbuild configs. It would be great to maintain this from a single place, ideally shipped as a package from prisma/prisma.

Dependency Dashboard

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

Ignored or Blocked

These are blocked by an existing closed PR and will not be recreated unless you click a checkbox below.

Detected dependencies

github-actions
.github/workflows/dry-publish.yml
  • actions/checkout v4
  • actions/setup-node v4
.github/workflows/publish-engines.yml
  • actions/checkout v4
  • actions/setup-node v4
  • benc-uk/workflow-dispatch v1
  • benc-uk/workflow-dispatch v1
  • benc-uk/workflow-dispatch v1
  • stefanzweifel/git-auto-commit-action v5
  • rtCamp/action-slack-notify v2.3.0
npm
package.json
  • @actions/core 1.10.1
  • @sindresorhus/slugify 1.1.2
  • @types/node 18.19.34
  • @types/node-fetch 2.6.11
  • arg 5.0.2
  • chalk 4.1.2
  • execa 5.1.1
  • husky 7.0.4
  • is-ci 3.0.1
  • node-fetch 2.7.0
  • prettier 2.8.8
  • ts-node 10.9.2
  • typescript 4.9.5
packages/engines-version/package.json
  • @types/node 18.19.34
  • typescript 4.9.5

  • Check this box to trigger a request for Renovate to run again on this repository

Allow Jest to run ESM modules

Bug description

Some modules cannot be upgraded because they use ESM syntax. In turn, our tests fail.

How to reproduce

For example see #131

Expected behavior

We should be able to run the tests since we are able to compile ES modules.

Cannot find namespace 'debug' in 2.29.0

+ pnpm recursive run build
Scope: all 5 workspace projects
packages/engines-version build$ tsc -d
packages/get-platform build$ tsc -d
packages/engines-version build: Done
packages/get-platform build: Done
packages/fetch-engine build$ tsc -d
Error: packages/fetch-engine build: ../../node_modules/.pnpm/@[email protected]/node_modules/@prisma/debug/dist/index.d.ts(2,44): error TS2503: Cannot find namespace 'debug'.
packages/fetch-engine build: Failed
undefined
/home/runner/work/engines-wrapper/engines-wrapper/packages/fetch-engine:
 ERROR  @prisma/[email protected] build: `tsc -d`
Exit status 2

Extract `@prisma/debug` into its own repository

The goal of this is to have a clean architecture where prisma/prisma depends on prisma/engines-wrapper. At the moment prisma/prisma depends on prisma/engines-wrapper that depends on prisma/prisma through @prisma/debug.

To avoid maintenance burden, instead of separating it into another repo, we could change our publish script to only publish to only publish (ie. @prisma/debug) if it has changes to be published. We can also argue that @prisma/debug is a tool that does not even depend on the engines an is thus not subject to the same versioning. This could be the opportunity to set up a new repo for tools and manage it perhaps via changesets.

Context https://prisma-company.slack.com/archives/CUXLS0Z6K/p1631084401029500

GH Actions publish-engines: Surface npm package version

In https://github.com/prisma/engines-wrapper/blob/main/.github/workflows/publish-engines.yml we receive a payload, and use that to update a dependency in this repo, then publish a new version to Npm. That Npm package version is not really visible here, but would make it easier to find stuff when debugging problems.

Possibilities:

  • Tag commit with Npm version (after it was actually published)
  • Add npm version to commit message (before the publish happened)
  • ...

Action Required: Fix Renovate Configuration

There is an error with this repository's Renovate configuration that needs to be fixed. As a precaution, Renovate will stop PRs until it is resolved.

File: renovate.json
Error type: Invalid JSON (parsing failed)
Message: Syntax error: expecting String near uke4"], }

support for ubuntu 22.04 openssl-3.0.x

i am getting the below error, when tried npx prisma generate

Error: Unknown binaryTarget debian-openssl-3.0.x and no custom binaries were provided

node version: v16.17.0
@prisma/client version: 3.13.0
openssl version: OpenSSL 3.0.2 15 Mar 2022 (Library: OpenSSL 3.0.2 15 Mar 2022)

i also tried by adding this line binaryTargets = ["native", "debian-openssl-3.0.x"] to schema.prisma. but getting the same error.

-- note: tried reinstalling the node_modules and also installed the @prisma/client version > 4.x.x

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.