Can you assist me in satisfying promises aplus spec 2.2.4 in NodeJS? about promises-spec HOT 4 OPEN

You don't seem to have provided the code for your entire adapter (e.g. where is executorResponseFunc defined?) so it's very difficult to know what's going on here. Ideally, provide us all the code and then maybe someone can have a quick look.

from promises-spec.

Hi - sorry my thinking was wrong
http://stackoverflow.com/questions/33629004/can-you-assist-me-in-satisfying-promises-aplus-spec-2-2-4-in-nodejs
Thanks for your help :)

On Tue, Nov 10, 2015 at 4:25 PM, Forbes Lindesay [email protected]
wrote:

You don't seem to have provided the code for your entire adapter (e.g.
where is executorResponseFunc defined?) so it's very difficult to know
what's going on here. Ideally, provide us all the code and then maybe
someone can have a quick look.

—
Reply to this email directly or view it on GitHub
#217 (comment)
.

from promises-spec.

You should never return from a constructor. If you need to do inheritance (you almost certainly don't) then use extends and super rather than returning from the constructor. If you don't need inheritance (again, I'm pretty sure you don't), just use functions instead of classes. It looks like your code could simplify to just

function HTTPromise(options) {
    ... blah blah blah
    let executor = THE_REAL_EXECUTOR;
    return new Promise(executor);
}

P.S. it sounds like what you're doing is very similar to then-request which has implementations for both browser and server side. It demonstrates how to write a function that returns a promise and how to extend that promise with an extra method (.getBody).

from promises-spec.

thanks i appreciate your input
i know you should never return a promise from a constructor but on this
occassion we discussed it and have very valid reasons for doing so, won't
bore you with them - thanks ever so much for your help :)

On Tue, Nov 10, 2015 at 6:14 PM, Forbes Lindesay [email protected]
wrote:

You should never return from a constructor. If you need to do inheritance
(you almost certainly don't) then use extends and super rather than
returning from the constructor. If you don't need inheritance (again, I'm
pretty sure you don't), just use functions instead of classes. It looks
like your code could simplify to just

function HTTPromise(options) {
... blah blah blah
let executor = THE_REAL_EXECUTOR;
return new Promise(executor);
}

P.S. it sounds like what you're doing is very similar to then-request
https://github.com/then/then-request which has implementations for both
browser and server side. It demonstrates how to write a function that
returns a promise and how to extend that promise with an extra method (
.getBody).

—
Reply to this email directly or view it on GitHub
#217 (comment)
.

from promises-spec.