Make API more flexible about react-native-netinfo HOT 4 CLOSED

I completely hear you on the "future proof" title 😉 I originally had it as "update" but changed it at the last minute.

It sounds like there's a desire to go ahead with something like this. I think the steps for this are:

1. Start a next branch which will include the next version of the API.
2. Add the new API structure but keep the feature set the same.
3. Add backward compatibility. If I can do this in a nice way then it can live in the library for a while before we remove it.
4. Add in hooks support. We may as well do this at the same time as we'll require a higher version of React Native, which I believe is classed as a breaking change. Plus it's a good reason for people to update if they want to use the "new shiny".
5. Merge into master as a breaking change.
6. Work on adding the new features where possible (eg. Adding the isInternetReachable flags). Release these as minor versions when ready.

from react-native-netinfo.

I think this looks good, as a typescript consumer of the "expensive or not" information, and isConnected etc, and also someone thinking about a breaking change in @rnc/device-info.

It seems like a fair change with useful API on first glance. The only thinking-out-loud idea I had while reading it was that if you wanted to make sure you were future proof at the API level you might want to make sure you modeled after the underlying network stack (note that isconnected and isinternetreachable are sort of like different layers in the ISO stack right? so maybe have a kind of yes/no lookup on those layers, but I'm not advocating that - it sounds terrible as I type it, just thinking out loud about what the info means as it comes through this module as maybe a criteria for correct thinking on API produced)

As a consumer I love a model where you introduce new API and deprecate/yellow-box (with docs to suppress) in one major rev, then purge deprecated API in second major rev. As a maintainer I feel the load of extra code but I don't mind personally. So I would do that if possible, if it were me.

from react-native-netinfo.

just as an aside on the term "future proof" as a ripoff of the joke about making things idiot-proof, the world is always inventing a worse future, so dunno about "future proof" but obviously we all (maintainers) try

from react-native-netinfo.

This has been released in v3.0.0 🎉

from react-native-netinfo.