Comments (12)
Fixed in #46
from react-navigation.
I can confirm this issue, and it is also related to issue #31.
I have tracked down this issue to the way DrawerNavigator
attempts to retrieve the components it renders. DrawerNavigator
internally uses a TabRouter
to find out what content it needs to render. However, whenever you nest a StackNavigator
, or in this case a TabNavigator
, this TabRouter
will retrieve the deepest component in the navigation tree, bypassing all intermediary navigators from rendering.
The root cause of this seems to lie in TabRouter's
getComponentForState
function, which will automatically recurse through all child routers:
getComponentForState(state: NavigationState) {
const routeName = order[state.index];
invariant(
routeName,
`There is no route defined for index ${state.index}. Check that
that you passed in a navigation state with a valid tab/screen index.`
);
const childRouter = tabRouters[routeName];
if (childRouter) {
return childRouter.getComponentForState(state.routes[state.index]);
}
return getScreenForRouteName(routeConfigs, routeName);
},
Bypassing/removing this recursion allows tabs and stacks inside drawers to function normally. However, I want to hold off on a PR as I assume this recursion is there for a reason, and I do not yet grok react-navigation
sufficiently to fully understand the consequences.
I believe that, ideally, DrawerNavigation should get its own router to cleanly separate concerns with TabRouter.
@ericvicenti @skevy Any insight for us laypeople?
from react-navigation.
Wow 4 hours after my issue, thank you ! Best.Customer.Service.Ever
from react-navigation.
Can confirm the same issue with embedding StackNavigators in a DrawerNavigator
from react-navigation.
Maybe the drawer navigator should use the router.getComponentForRouteName
instead? If you can find a fix inside the drawer navigator without changing any routers, then the PR would be quickly accepted!
cc @satya164
from react-navigation.
from react-navigation.
Thanks @satya164! FYI, I was doing the same fix at the same time. I have tested it in the following scenarios:
Tab in Drawer --> ok
Tab in Tab in Drawer --> ok
Stack in Tab in Drawer --> ok
Tab in Drawer in Tab --> ok
Tab in Drawer in Stack --> ok
... so we should be golden!
from react-navigation.
Awesome!
from react-navigation.
How can we handle the scenarios of Drawer inside the Tab , Can you please point me to some working code ?
from react-navigation.
That would be interesting. Or a way to have both - a TabNavigator and a DrawerNavigator.
I have a project where I should have 3 Tabs on all screens and a drawer with other NavigationItems.
from react-navigation.
from react-navigation.
Which link should I share? It is more or less a question ... will try to join this with a stacknavigator or so.
from react-navigation.
Related Issues (20)
- 'createDrawerNavigator' is crashing the app
- Height of header with active search input seems to be ignored during back navigation transition on iOS
- 7.0.0-alpha `static` router conditional not working on iOS HOT 6
- Issue unit testing a navigation container (createInteractionHandle is not a function) HOT 3
- Elements with `position: absolute` disappear during screen transition HOT 3
- Crash due to useNativeDriver true for tab animations with android 12 devices HOT 2
- Cannot read property 'name' of undefined in "MaterialTopTabView" HOT 4
- Dropdown and popover components opening at incorrect position in iOS when using default header in React Navigation 6 stack HOT 2
- getState typescript error after version 6.1.10 HOT 1
- Header height not getting calculated in pageY value for components in new architecture HOT 3
- Incorrect pageY value when only using default header of react navigation stack in new architecture HOT 3
- v7 Navigating back randomly causes NAVIGATE action to be dispatched instead of GO_BACK HOT 2
- Possible EventEmitter memory leak detected HOT 1
- Pressable interaction issue with StackNavigator on iPhone Xs + new architecture HOT 8
- 7.0.0-alpha.15 @react-navigation/material-top-tabs - tabBarIcons are not showing. HOT 4
- Adjust the margin of the bottom menu bar HOT 3
- DRAWER ENCERRA O APLICATIVO HOT 10
- Sometimes duplicate tab bar labels appear in bottom tabs HOT 1
- unmountOnBlur shows white screen randomly when switchint tabs HOT 1
- useHeaderHeight changes several times when orientation changes HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-navigation.