TextView support about input-mask-ios HOT 4 CLOSED

Hey @AlexisQapa, thanks for your question.

I'm on a short vacation right now, unfortunately.
I'll be able to add UITextView support early next week. I suppose this new module to be quite similar to the current UITextFieldDelegate implementation in our library, so it shouldn't take long.

Stay tuned for upcoming updates!

from input-mask-ios.

I've been playing a bit with it and I got it working. It's mostly changing methods signatures except for two things that will need discussion :

• there is no clear button so : textViewShouldClear(_ textView: UITextView) -> Bool is useless. Maybe you could keep it somehow so if one add a clear button he can get the same behaviour.

• the done button input a newline instead of delegating keyboard dismissal. You could add a toggle with something like :
  open func textView(_ textView: UITextView, shouldChangeTextIn range: NSRange, replacementText text: String) -> Bool { // Hack to detect enter key if toggle { let resultRange = text.rangeOfCharacter(from: .newlines, options: .backwards) if text.count == 1 && resultRange?.lowerBound != nil { textView.resignFirstResponder() return false } } ...
  in order to have the same behaviour as for the TextField but keep it optin as it's mostly a hack and ppl may want to input newLines.

Finally, you may want to have only one delegate class, so maybe a wrapper or the listener could implement UITextFieldDelegate and UITextViewDelegate

from input-mask-ios.

@AlexisQapa, thanks for your comments, you pretty much described the final solution.

Future UITextFieldDelegate and UITextViewDelegate objects are expected to contain lots of common logic, which brings us to the obvious need of refactoring. Repetitive code is not an option.

Though we've got a minor backward compatibility issue, as our current library listener is called a MaskedTextFieldDelegate, and I've got to retain this TextFieldDelegate naming in order to avoid breaking things. Thus, I'll need to consider a gradual refactoring or something. Nevertheless, there's nothing to be concerned about. Will see next week.

from input-mask-ios.

Implemented in 3.5.0.

from input-mask-ios.