Giter VIP home page Giter VIP logo

Comments (4)

ericf avatar ericf commented on September 27, 2024

Also, I'm unsure that even the implementation in <= 0.2.1 would even work in Express 3.x since the handler function always calls next() which will lead to a 404 since res.send() was never called.

from combohandler.

evocateur avatar evocateur commented on September 27, 2024

Oh, dang. Guess we should have a test for that case.

I'll have to do some digging to figure out when we know we're being used directly, vs in a route callback chain...

from combohandler.

ericf avatar ericf commented on September 27, 2024

I think it's fine to add a new function to serve this feature which basically would have to manually call into the other middleware functions and can't rely on next().

from combohandler.

evocateur avatar evocateur commented on September 27, 2024

Yeah, I have an angle on inspecting the req.route.callbacks array, see if the current middleware is the end of the chain, and then just res.send(res.body) instead of next(). I fiddled with it a couple weeks ago (hence naming some of the anonymous functions returned as middleware), it's crazy what Express gives access to in the req and res objects.

from combohandler.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.