This breaks on ipv4 => ipv6 conversion about express-ipfilter HOT 7 CLOSED

@Aedaeum my only concern is making any assumptions about how an IP should be handled. I agree with you that it would make sense that if you had the one, just honor the other, but if that created an issue for someone else and they weren't expecting it, that would seem to be worse than having to add both the IPv4 and IPv6 addresses.

from express-ipfilter.

+1

from express-ipfilter.

I just merged #44 which should fix this problem. If you are still having issues with the new version, feel free to reopen.

from express-ipfilter.

@ryanbillingsley This fixes the overall issue, but does not resolve the ::1 IP reserved for localhost connections. You'll notice in my code example, I converted it to its proper IP address.

from express-ipfilter.

@Aedaeum you can't just add ::1 to your list of IPs?

from express-ipfilter.

@ryanbillingsley Yes, I can. I just figured it would be more intuitive from a programming perspective to have 127.0.0.1 handle all localhost connections.

edit Without digging into the IPs, I didn't realize myself that ::1 was localhost, so I imagine other people will have this same issue.

from express-ipfilter.

@ryanbillingsley I agree with that. I'm not sure about the ramifications either.

from express-ipfilter.