Giter VIP home page Giter VIP logo

Comments (5)

mr339 avatar mr339 commented on September 27, 2024

what was this closed? im also facing the same issue @mugu-fatman

from leaflet-geosearch.

gjvoosten avatar gjvoosten commented on September 27, 2024

Same here:
Screenshot from 2023-10-11 13-25-57

Downgrading to the previous version makes the error disappear. Please reopen or provide a reason why this was closed.

Note that the reason for the exception appears to be that validateCoords(query) is called with an undefined query, so this change would fix it:

diff --git a/src/coords.ts b/src/coords.ts
index b874b8e..e413608 100644
--- a/src/coords.ts
+++ b/src/coords.ts
@@ -1,7 +1,7 @@
 // @ts-nocheck
 
 export function validateCoords(query) {
-  const q = query.trim();
+  const q = query?.trim();
   const regex = /^(-?[0-9]*\.?\s*[0-9]*)\s*,?\s*(-?[0-9]*\.?[0-9]*)$/g;
   const match = regex.exec(q);
   if (match) {

from leaflet-geosearch.

mtmail avatar mtmail commented on September 27, 2024

mugu-fatman closed it himself. It wasn't the library maintainer.

from leaflet-geosearch.

gjvoosten avatar gjvoosten commented on September 27, 2024

I've opened a new issue #382 and PR #383

from leaflet-geosearch.

mugu-fatman avatar mugu-fatman commented on September 27, 2024

Thank you, There was already another issue opened for the same reason

from leaflet-geosearch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.