SSL on embedded tomcat not picking up env properties via @Value about spring-boot HOT 5 CLOSED

Your problem is that you don't let Spring create the AppTomcatConnectorCustomizer for you. If you leave out that section of the EmbeddedServletContainerCustomizer it should work, e.g.

    @Bean
    public EmbeddedServletContainerCustomizer containerCustomizer(){
        return new EmbeddedServletContainerCustomizer() {
            @Override
            public void customize(ConfigurableEmbeddedServletContainerFactory factory) {
                factory.addErrorPages(new ErrorPage(HttpStatus.NOT_FOUND, "/error/404.html"));
            }
        };
    }

and the @ComponentScan will pick up the AppTomcatConnectorCustomizer.

This is useful stuff though, so thanks for the sample. It will help get the Tomcat piece of #101 together. Anything you can do to show the steps for Jetty will be tremendously helpful too.

from spring-boot.

Thanks Dave. Just getting to a PC. With the section of the EmbeddedServletContainerCustomizer left out, the AppTomcatConnectorCustomizer is still never registered. What works though is autowiring it so that spring does the instantiation instead of doing it via new myself.

I pushed the solution that worked for me up. Let me know if I am missing something.

On the jetty front, I'll work up something tomorrow.

Thanks for your help.

from spring-boot.

I'll actually leave this reopened awhile pending Dave's input. If the customizer should be picked up via @ComponentScan without the EmbeddedServletContainerCustomizer logic, then appears that is a bug? Can't get it to work without that logic

from spring-boot.

Actually I think the current behaviour is correct. If you think it should work differently you can say why here, but my inclination is to leave it as it is (otherwise we'd end up doing autowiring of all the TomcatEmbeddedServletContainerFactory extension points, and the same for Jetty).

from spring-boot.

Makes sense Dave. Thanks. That is what I figured, but based on your previous feedback, I thought I might be doing something wrong. The functionality is fine the way it is.

from spring-boot.