Run yarn
to install the dependencies
yarn
Copy .env.testnet example to .env then run the app using the script provided
cp .env.testnet .env
yarn dev
We should add notifications similar to the 3 steps of auction creation through out the application.
Interfaces that require notifications are:
I can't quite figure out what these triangles are for on the filters for "sell" and "min bid". Sorry! I clicked them multiple times .... oh I see it's sorted by the bid amount ascending/descending.
Also, it's not clear -- is that column the latest bid amount? That's my guess, but maybe the list view should have a header.
This is a font awesome sorting icon that might be more intuitive:
Viewing the Bidding page for an auction briefly displays NaN (not a number) and Invalid Date before displaying the actual auction details.
Maybe the display can default to blank data until the data values are set.
I think this is low priority @cankisagun, but it would help with user confidence in the auction secret app to not see those values 😀
This is kind of a minor UI improvement suggestion ... after clicking on the "Update Asking Price" button and entering a new price there's a button that says "Enter" to submit the change.
I think it should be something other than "Enter" ... like "Submit" or "Update" to affirm the action the user is taking. Unless "Enter" is the preferred action verbiage?
Feel free to close this if it doesn't make sense!
Currently I have to look at keplr to see my balances for the assets i'm interested in
It would be nice to show the balances like shown in scrtlabs/EthereumBridgeFrontend#53
Haha I didn't really understand what it meant when I created the auction, but I did it because I was supposed to.
From what I can tell it just gets the tokens I'm selling and deposits them into the auction contract, like an escrow.
Maybe change the verbiage to something like that?
I think that the average user of the Secret Auctions app doesn't really care that it's a factory contract that the tokens are being transferred to and locked ... kind of thinking in layman's terms here. This verbiage is something a developer would be interested in knowing though imho.
There appears to be some confusion about why an auction stays open and accepts bids after the ends at time. Since the ends at time is only when ANYONE can close the auction, not actually a forced time to close, maybe we should just label the time "anyone can close at" or something similar (but more eloquent lol)
Because the Bid button launches the auction info page, which includes change minimum and close auction buttons. Maybe just name the button "View" to launch the same page, since you have to use that button to do things other than bid.
Ideally we should think about the main call to action for different uesrs
Bidder
Seller
I clicked on "Change minimum bid" and didn't actually change the amount, then clicked "Change ..." and the Secret Auction app started the Keplr interaction.
Just need a check so that the "Change ..." button is disabled until the minimum bid is changed. Or some other solution, like a validator error saying the amount hasn't been changed.
It would be great if this was styled so it's easier on the eyes. 😄
Suggestions:
During creation, the closing time dropdown options are minute and hour. When extending an auction if offers minute, hour, day, and week. I think it would be best if they both offered the same time units
People might still want to look at the auction description or other data after it has closed, so maybe add an "info" button that would do an auction_info query and go to the appropriate screen
If the auction closed with a winner, the list of closed auctions should display the winning bid
Does status need to show that "tokens are consigned" as it's automated in the last iteration?
I suggest we just say "Accepting Bids" unless there's no scenario where tokens are not consigned or if that's possible, I would rather have two states:
It wasn't clear to me that these were filters, initially, until I clicked the dropdowns and started choosing specific coins.
I think it would be great to make it more clear that those are search filters.
Also, the "min bid" label doesn't seem to fit because the user's not really filtering on minimum bid amounts.
I created an auction and also the viewing key (as part of the new auction process). I can see the viewing key, but the filter to select auctions create by me is disabled.
Also, in Grid or List view when the user is viewing the auctions, it would be helpful to denote in some visual way which ones are my auctions.
The increase allowance function defaults to using 1m gas. It costs under 110k, probably play it safe and pad that to 150k to give a little leeway for people writing their own token contracts that might be less efficient (or do more processing) than the reference implementation
The create auction tx defaults to 1m. It costs around 600k. Probably give this one an extra buffer and set it to 700k, since we do not really know how many active auctions there will be at one time.
create viewing key function defaults to 1m gas, but costs under 110k. 120k should be safe here.
When I click on Place Bid, I'm not shown any notification although I can see that tokens have been moved by checking Keplr balances. Let's add a notification or pop up saying bid submitted or transaction confirmed. If helpful, pls tag @dogemos on discord to see how to add these
Also, the status of having open bids in the auction should change after I submit a bid
I clicked on an auction using the "Bid" button and once there reloaded the page and got a 404 - not found error.
Going back to the grid or list view the auction is shown, but clicking on the "Bid" button results in the same 404 error
However, it seems to be temporary! A few minutes later going back to the Auctions list and clicking on "Bid" for the auction in question displayed the correct information.
I'm not sure how to put this exactly, but I placed a bid on an auction and then closed the auction. I didn't receive the tokens so I can only assume that my bid wasn't the highest bid.
It would be great to give the user more info there if possible in the context of a secret auction. For example, I'd like to see (on the Bidding Page):
This way I could place a higher bid before closing the auction to make sure I win the tokens! :-D
Step 1: Fill the form -> Fill auction details
When I first clicked on the Key icon, I saw the viewing key for the "Factory address" and a button to create a viewing key.
I went ahead and created a viewing key, but I'm not sure that I needed to ... also, what is the UI referring to for the factory address?
I think maybe just adding a bit of verbiage to that window would make it easier for the user to understand.
I forget which auction I clicked "Bid" on 🤯.
In the Grid or List view it's visually easy to see what I'm selecting:
but on the Bid page it's not so obvious. I'm wondering about maybe adding a title line that has the token icon and the auction token info:
similar to this, but on the same title line or something to that effect.
The Bid button should be disabled or not visible for an auction where the user is a seller.
Maybe change "Bid" to "View"? I haven't gotten far enough to see if that makes sense though. Oh wait, the seller can change the minimum bid from clicking on that button so maybe it should say "Manage" or "Edit" instead of "Bid".
And if it's the seller editing their auction, leave out the fields and button for placing a bid.
Two snapshots below: 1) showing the initial state of the bid price and minimum bid info and 2) the values of the fields after the default bid price has been modified.
Not sure why the minimum bid price changes as you modify the bid price. If it's correct behavior, maybe add a note to that area explaining what's happening.
I changed the bid price to 340 and the minimum bid field was automatically updated to be 1700.
It's possible I missed it, but I don't see the ability to input the token addresses instead of using the presets from the drop down.
We want people to be able to create and sell their own SNIP20s, so there should be an option to input a token address (and the UI will look up the matching code hash needed for the create_auction message)
Sometimes hovering over a button or icon displays the "hand" icon and other times it's the "arrow" icon.
Buttons or other elements that are using the "arrow" icon:
Buttons or other elements that are using the "hand" icon:
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.